From c63c48cc357aecdd1a584e4102e7cfff74702229 Mon Sep 17 00:00:00 2001 From: ivan Date: Sun, 5 Sep 2004 09:41:33 +0000 Subject: [PATCH] acquire a database lock to prevent race conditions in duplicate checking --- FS/FS/svc_acct.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/FS/FS/svc_acct.pm b/FS/FS/svc_acct.pm index f935df50d..ded796ff7 100644 --- a/FS/FS/svc_acct.pm +++ b/FS/FS/svc_acct.pm @@ -247,6 +247,13 @@ sub insert { #new duplicate username/username@domain/uid checking + #this is Pg-specific. what to do for mysql etc? + # ( mysql LOCK TABLES certainly isn't equivalent or useful here :/ ) + warn "$me locking svc_acct table for duplicate search" if $DEBUG; + dbh->do("LOCK TABLE svc_acct IN SHARE ROW EXCLUSIVE MODE") + or die dbh->errstr; + warn "$me acquired svc_acct table lock for duplicate search" if $DEBUG; + my $part_svc = qsearchs('part_svc', { 'svcpart' => $self->svcpart } ); unless ( $part_svc ) { $dbh->rollback if $oldAutoCommit; -- 2.11.0