From 9f9bf2008844e95b0d93c73626ea134b7f97a2f8 Mon Sep 17 00:00:00 2001 From: ivan Date: Thu, 23 Apr 2009 04:14:54 +0000 Subject: [PATCH] does pg try to finish the query when the job addition is committed? well, if this works, that answers that. RT#4412 --- FS/FS/Cron/bill.pm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/FS/FS/Cron/bill.pm b/FS/FS/Cron/bill.pm index 4e8817343..5101e0dad 100644 --- a/FS/FS/Cron/bill.pm +++ b/FS/FS/Cron/bill.pm @@ -4,6 +4,7 @@ use strict; use vars qw( @ISA @EXPORT_OK ); use Exporter; use Date::Parse; +use DBI 1.33; #The "clone" method was added in DBI 1.33. use FS::UID qw(dbh); use FS::Record qw(qsearchs); use FS::cust_main; @@ -102,16 +103,18 @@ END warn "searching for customers:\n". join("\n", @search). "\n" if $opt{'v'} || $opt{'l'}; - dbh->do( - "DECLARE cron_bill_cursor CURSOR WITH HOLD FOR ". #no WITH HOLD for mysql? + my $cursor_dbh = dbh->clone; + + $cursor_dbh->do( + "DECLARE cron_bill_cursor CURSOR FOR ". " SELECT custnum FROM cust_main ". " WHERE ". join(' AND ', @search). " ORDER BY custnum " #LIMIT 1000 " - ) or die dbh->errstr; + ) or die $cursor_dbh->errstr; while ( 1 ) { - my $sth = dbh->prepare('FETCH 1000 FROM cron_bill_cursor'); #mysql? + my $sth = $cursor_dbh->prepare('FETCH 100 FROM cron_bill_cursor'); #mysql? $sth->execute or die $sth->errstr; @@ -156,6 +159,8 @@ END } + $cursor_dbh->commit or die $cursor_dbh->errstr; + } 1; -- 2.11.0