From 9a753a28cb38ddf6e500805246173a8a1d12894a Mon Sep 17 00:00:00 2001 From: Mark Wells Date: Mon, 5 Aug 2013 18:04:44 -0500 Subject: [PATCH] always bill ipifony charges within the month they were imported, #24325 --- FS/bin/freeside-ipifony-download | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/FS/bin/freeside-ipifony-download b/FS/bin/freeside-ipifony-download index 9df4db08a..51db035d5 100644 --- a/FS/bin/freeside-ipifony-download +++ b/FS/bin/freeside-ipifony-download @@ -183,11 +183,24 @@ FILE: foreach my $filename (@$files) { if $opt{v}; my $amount = sprintf('%.2f',$hash{quantity} * $hash{unit_price}); + + # bill the charge on the customer's next bill date, if that's within + # the current calendar month; otherwise bill it immediately + # (see RT#24325) + my $next_bill_date = $cust_main->next_bill_date; + if ( $next_bill_date ) { + my ($bill_month, $bill_year) = (localtime($next_bill_date))[4, 5]; + my ($this_month, $this_year) = (localtime(time))[4, 5]; + if ( $this_month == $bill_month and $this_year == $bill_year ) { + $cust_main->set('charge_date', $next_bill_date); + } + } + # construct arguments for $cust_main->charge my %charge_opt = ( amount => $hash{unit_price}, quantity => $hash{quantity}, - start_date => $cust_main->next_bill_date, + start_date => $cust_main->get('charge_date'), pkg => $hash{date_desc} . ' (' . $hash{quantity} . ' @ $' . $hash{unit_price} . ' ea)', taxclass => $TAXCLASSES{ $hash{taxclass} }, @@ -244,7 +257,7 @@ foreach my $custnum ( keys (%e911_qty) ) { my $cust_pkg = FS::cust_pkg->new({ pkgpart => $opt{e}, custnum => $custnum, - start_date => $cust_main->next_bill_date, + start_date => $cust_main->get('charge_date'), quantity => $quantity, }); my $error = $cust_main->order_pkg({ cust_pkg => $cust_pkg }); -- 2.11.0