From 98d8b209eaa505466f20f3a4e2f8e597def34852 Mon Sep 17 00:00:00 2001 From: ivan Date: Fri, 14 Sep 2007 02:14:07 +0000 Subject: [PATCH] turn off Text::Quoted usage, it segfaults and its optional --- rt/html/Ticket/Elements/ShowTransactionAttachments | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/rt/html/Ticket/Elements/ShowTransactionAttachments b/rt/html/Ticket/Elements/ShowTransactionAttachments index 9a66ee780..b014d07c6 100644 --- a/rt/html/Ticket/Elements/ShowTransactionAttachments +++ b/rt/html/Ticket/Elements/ShowTransactionAttachments @@ -139,8 +139,14 @@ unless ( ($message->GetHeader('Content-Disposition')||"") =~ /attachment/i ) { # if it's a text/plain show the body elsif ( $message->ContentType =~ m{^(text|message|text)}i ) { - eval { require Text::Quoted; $content = Text::Quoted::extract($content); }; - if ($@) { 1; } + #don't want to use this even if it is installed, its + #segfaulting on weird characters and silently truncating the + #ticket history output + #see: + # r44838@pinglin: jesse | 2006-11-14 15:53:18 -0500 + # * Move Text::Quoted back to being a run-time require. So that it's possible to turn off the feature if it causes your perl to segfault. (Text::Tabs is...not robust in the face of perl bugs) + #eval { require Text::Quoted; $content = Text::Quoted::extract($content); }; + #if ($@) { 1; } $m->comp( 'ShowMessageStanza', -- 2.11.0