From 8520df0677b0b2d9b66e0d01984a2f01b4d3b04b Mon Sep 17 00:00:00 2001
From: Ivan Kohler <ivan@freeside.biz>
Date: Sun, 5 Jan 2014 01:43:48 -0800
Subject: [PATCH] fix login with an existing session cookie, RT#25533

---
 fs_selfservice/FS-SelfService/cgi/selfservice.cgi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
index 13723118c..f84f5d633 100755
--- a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
@@ -105,7 +105,7 @@ unless ( $nologin_actions{$action} ) {
 
   my %cookies = CGI::Cookie->fetch;
 
-  my $login_rv;
+  my $login_rv = {};
 
   if ( exists($cookies{'session'}) ) {
 
@@ -178,10 +178,7 @@ unless ( $nologin_actions{$action} ) {
 
     } # else session_id ne 'login'
 
-  } else {
-    # there is no session cookie
-    $login_rv = {};
-  }
+  } # else there is no session cookie
 
   if ( !$session_id ) {
     # XXX why are we getting agentnum from a CGI param? surely it should 
-- 
2.11.0