From 754f419aa67a58a58fa890e14b1239f3e42d23c6 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Wed, 18 Sep 2019 15:54:25 -0700 Subject: [PATCH] more efficient invoice voiding, RT#80366 --- FS/FS/cust_bill_pkg.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/FS/FS/cust_bill_pkg.pm b/FS/FS/cust_bill_pkg.pm index 305ad63a6..6f9c74a64 100644 --- a/FS/FS/cust_bill_pkg.pm +++ b/FS/FS/cust_bill_pkg.pm @@ -6,7 +6,7 @@ use vars qw( @ISA $DEBUG $me ); use Carp; use List::Util qw( sum min ); use Text::CSV_XS; -use FS::Record qw( qsearch qsearchs dbh ); +use FS::Record qw( qsearch qsearchs dbh fields ); use FS::cust_pkg; use FS::cust_bill_pkg_detail; use FS::cust_bill_pkg_display; @@ -429,8 +429,10 @@ sub void_cust_bill_pkg_detail { $self->billpkgnum ); - $self->scalar_sql("INSERT INTO cust_bill_pkg_detail_void - SELECT * $from_cust_bill_pkg_detail", + my $fields = join(', ', fields('cust_bill_pkg_detail_void') ); + + $self->scalar_sql("INSERT INTO cust_bill_pkg_detail_void ($fields) + SELECT $fields $from_cust_bill_pkg_detail", $self->billpkgnum ); -- 2.11.0