From 2bdb2bb70aee8faf11da3b09f110be892103c0a7 Mon Sep 17 00:00:00 2001 From: ivan Date: Tue, 24 Aug 2010 20:11:08 +0000 Subject: [PATCH] ensure signup payments are applied, RT#9689 --- FS/FS/ClientAPI/Signup.pm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/FS/FS/ClientAPI/Signup.pm b/FS/FS/ClientAPI/Signup.pm index a4032f3b1..2aca88c98 100644 --- a/FS/FS/ClientAPI/Signup.pm +++ b/FS/FS/ClientAPI/Signup.pm @@ -641,14 +641,14 @@ sub new_customer { if ( $conf->exists('signup_server-realtime') ) { - #warn "[fs_signup_server] Billing customer...\n" if $Debug; + #warn "$me Billing customer...\n" if $Debug; my $bill_error = $cust_main->bill; - #warn "[fs_signup_server] error billing new customer: $bill_error" + #warn "$me error billing new customer: $bill_error" # if $bill_error; $bill_error = $cust_main->apply_payments_and_credits; - #warn "[fs_signup_server] error applying payments and credits for". + #warn "$me error applying payments and credits for". # " new customer: $bill_error" # if $bill_error; @@ -656,7 +656,7 @@ sub new_customer { method => FS::payby->payby2bop( $packet->{payby} ), depend_jobnum => $placeholder->jobnum, ); - #warn "[fs_signup_server] error collecting from new customer: $bill_error" + #warn "$me error collecting from new customer: $bill_error" # if $bill_error; if ($bill_error && ref($bill_error) eq 'HASH') { @@ -668,6 +668,11 @@ sub new_customer { }; } + $bill_error = $cust_main->apply_payments_and_credits; + #warn "$me error applying payments and credits for". + # " new customer: $bill_error" + # if $bill_error; + if ( $cust_main->balance > 0 ) { #this makes sense. credit is "un-doing" the invoice -- 2.11.0