From: ivan Date: Wed, 31 Jan 2001 07:21:00 +0000 (+0000) Subject: fix tyops X-Git-Tag: freeside_1_3_0~42 X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=d746dfce2e320169ec8217cb09b9dbb0d403675d fix tyops --- diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm index bb774df1c..e50ea7198 100644 --- a/FS/FS/cust_main.pm +++ b/FS/FS/cust_main.pm @@ -806,7 +806,7 @@ sub collect { } elsif ( $processor eq 'cybercash3.2' ) { %result = &CCMckDirectLib3_2::SendCC2_1Server(@full_xaction); } else { - return "Unkonwn real-time processor $processor\n"; + return "Unknown real-time processor $processor\n"; } #if ( $result{'MActionCode'} == 7 ) { #cybercash smps v.1.1.3 @@ -832,7 +832,7 @@ sub collect { } } else { - return "Unkonwn real-time processor $processor\n"; + return "Unknown real-time processor $processor\n"; } } else { #batch card @@ -999,7 +999,7 @@ sub check_invoicing_list { =head1 VERSION -$Id: cust_main.pm,v 1.8 2001-01-23 05:03:50 ivan Exp $ +$Id: cust_main.pm,v 1.9 2001-01-31 07:21:00 ivan Exp $ =head1 BUGS diff --git a/FS/FS/svc_acct.pm b/FS/FS/svc_acct.pm index d2e3918da..9d2db0eff 100644 --- a/FS/FS/svc_acct.pm +++ b/FS/FS/svc_acct.pm @@ -170,7 +170,7 @@ sub insert { if qsearchs( 'svc_acct', { 'username' => $self->username } ); my $part_svc = qsearchs( 'part_svc', { 'svcpart' => $self->svcpart } ); - return "Unkonwn svcpart" unless $part_svc; + return "Unknown svcpart" unless $part_svc; return "uid in use" if $part_svc->svc_acct__uid_flag ne 'F' && qsearchs( 'svc_acct', { 'uid' => $self->uid } ) @@ -385,7 +385,7 @@ sub check { $recref->{popnum} =~ /^(\d*)$/ or return "Illegal popnum: ".$recref->{popnum}; $recref->{popnum} = $1; - return "Unkonwn popnum" unless + return "Unknown popnum" unless ! $recref->{popnum} || qsearchs('svc_acct_pop',{'popnum'=> $recref->{popnum} } ); @@ -536,7 +536,7 @@ sub radius_check { =head1 VERSION -$Id: svc_acct.pm,v 1.13 2000-07-17 13:51:07 ivan Exp $ +$Id: svc_acct.pm,v 1.14 2001-01-31 07:21:00 ivan Exp $ =head1 BUGS diff --git a/TODO b/TODO index 54a00a111..9c9de34ea 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,4 @@ -$Id: TODO,v 1.56 2000-12-26 23:51:40 ivan Exp $ +$Id: TODO,v 1.57 2001-01-31 07:21:00 ivan Exp $ If you are interested in helping with any of these, please join the *development* mailing list (send a blank message to @@ -6,6 +6,52 @@ ivan-freeside-devel-subscribe@sisd.com) to avoid duplication of effort. --- +(future templating) +. +(at least) These questions need to be answered for Mason, Apache::ASP and +eperl. If eperl becomes too much of a pain, I'm okay with forgetting +about it - it's not well-maintained. The answers below are for Mason. +. +How do you interpolate a value? <% $value %> +. +How do you interpolate a value without escaping HTML? <% $value |n %> +. +How do you interpolate a (possibly non-stand-alone, non-interpolated) +control structure? With an inital % - for example: +. + % for each $value ( @values ) { + + % } +. +This is one of the things I worry that the webmonkey HTML editors will not +like about Mason. That and the <%INIT> and <%PERL> tags. + + +in the context of a state machine (& MySQL and Pg locking) for LDAP export: +. +Also note that Pg locks are for the duration of the transaction, so +Freeside needs to start using transactions for this to happen. +FS::UID::adminsuidsetup should explicitly set AutoCommit false and export +some functions to begin and end transactions on $FS::UID::dbh. (Well, +eventually FS::UID should be an overloaded subclass of a DBI handle, but +we don't have to worry about that until perl threads + mod_perl + threaded +Apache 2.0 is stable, i.e. quite some time). + +Postfix +also supports virtual domains in a way that's somewhat similar (but not +compatible with) the way sendmail does. In the postfix world, all virtual +domain info is contained in one file (similar to the virtusertable), but +is formatted as such: +bar.com virtual +foo@bar.com some@other.net +quux@bar.com localuser1 +... +and so on. After the file is generated, it gets compiled into a hash db +using, "postmap /etc/postfix/virtual". + + +steal all the play-nice-with-cache stuff back from RT + Use this for email checking: libemail-valid-perl - Check validity of Internet email addresses . @@ -106,6 +152,7 @@ Yes, but we're small and have been tracking projects manually. first package select field in edit/cust_main.cgi isn't sticky on errors, yuck +(also referral isn't sticky either? yuck) > 1. A Web Form to the user get his account added automatically . The > /etc/raddb/users and /etc/passwd would be updated automatically (these diff --git a/htdocs/view/svc_acct.cgi b/htdocs/view/svc_acct.cgi index 22c3d76f2..40e3c2d15 100755 --- a/htdocs/view/svc_acct.cgi +++ b/htdocs/view/svc_acct.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: svc_acct.cgi,v 1.11 2000-12-03 20:25:20 ivan Exp $ +# $Id: svc_acct.cgi,v 1.12 2001-01-31 07:21:00 ivan Exp $ # # Usage: svc_acct.cgi svcnum # http://server.name/path/svc_acct.cgi?svcnum @@ -33,7 +33,10 @@ # displays arbitrary radius attributes ivan@sisd.com 98-aug-16 # # $Log: svc_acct.cgi,v $ -# Revision 1.11 2000-12-03 20:25:20 ivan +# Revision 1.12 2001-01-31 07:21:00 ivan +# fix tyops +# +# Revision 1.11 2000/12/03 20:25:20 ivan # session monitor updates # # Revision 1.10 1999/04/14 11:27:06 ivan @@ -91,7 +94,7 @@ $mydomain = $conf->config('domain'); $query =~ /^(\d+)$/; $svcnum = $1; $svc_acct = qsearchs('svc_acct',{'svcnum'=>$svcnum}); -die "Unkonwn svcnum" unless $svc_acct; +die "Unknown svcnum" unless $svc_acct; $cust_svc = qsearchs('cust_svc',{'svcnum'=>$svcnum}); $pkgnum = $cust_svc->getfield('pkgnum'); @@ -104,7 +107,7 @@ if ($pkgnum) { } $part_svc = qsearchs('part_svc',{'svcpart'=> $cust_svc->svcpart } ); -die "Unkonwn svcpart" unless $part_svc; +die "Unknown svcpart" unless $part_svc; $p = popurl(2); print $cgi->header( '-expires' => 'now' ), header('Account View', menubar(