From: Ivan Kohler <ivan@freeside.biz>
Date: Tue, 7 Mar 2017 05:33:26 +0000 (-0800)
Subject: detect errors on the scp portion of the backup, RT#74914
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=bf0217c19f5aeff191fe3354cafe0deaadcf1064

detect errors on the scp portion of the backup, RT#74914
---

diff --git a/FS/FS/Cron/backup.pm b/FS/FS/Cron/backup.pm
index a192ca90e..7d868c882 100644
--- a/FS/FS/Cron/backup.pm
+++ b/FS/FS/Cron/backup.pm
@@ -58,7 +58,9 @@ sub backup {
   if ( $scpdest ) {
     eval "use Net::SCP qw(scp);";
     backup_log_and_die($filename,$@) if $@;
-    scp("/var/tmp/$database.$ext", "$scpdest/$filename.$ext");
+    my $scp = new Net::SCP;
+    $scp->scp("/var/tmp/$database.$ext", "$scpdest/$filename.$ext")
+      or backup_log_and_die($filename, $scp->{errstr});
   }
 
   unlink "/var/tmp/$database.$ext" or backup_log_and_die($filename,$!); #or just warn?