From: Mitch Jackson <mitch@freeside.biz>
Date: Tue, 28 Nov 2017 02:21:57 +0000 (+0000)
Subject: Change selectbox to checkbox on Credit Report form RT#73200
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=af27dbbf7740d0c77d725de905248639637e4f8f

Change selectbox to checkbox on Credit Report form RT#73200
---

diff --git a/httemplate/elements/tr-select-show_voided_credits.html b/httemplate/elements/tr-select-show_voided_credits.html
deleted file mode 100644
index 35c0cf401..000000000
--- a/httemplate/elements/tr-select-show_voided_credits.html
+++ /dev/null
@@ -1,15 +0,0 @@
-  <TR>
-    <TD ALIGN="right"><% $opt{'label'} || 'Show Voided Credits' %></TD>
-    <TD>
-      <select name='show_voided_credits'>
-        <option value=""></option>
-        <option value="0">no</option>
-        <option value="1">yes</option>
-      </select>
-    </TD>
-  </TR>
-<%init>
-
-my %opt = @_;
-
-</%init>
diff --git a/httemplate/search/cust_credit.html b/httemplate/search/cust_credit.html
index 468a01a77..956f2d2e4 100755
--- a/httemplate/search/cust_credit.html
+++ b/httemplate/search/cust_credit.html
@@ -33,14 +33,12 @@ my $clink = sub {
     : '';
 };
 
-# form selectbox for show_voided_credits:
-# - value='': use default from $conf
-# - value="0" : override default, do not show voided credits
-# - value="1" : override default, show voided credits
+# form checkbox for show_voided_credits:
+# - value=unset : do not show voided credits
+# - value="1"   : show voided credits
 my $show_voided_credits;
-$show_voided_credits = $conf->config('show_voided_credits');
 $show_voided_credits = $cgi->param('show_voided_credits')
-  if $cgi->param('show_voided_credits') =~ /^(\d)$/;
+  if $cgi->param('show_voided_credits');
 
 my (@header, @fields, @sort_fields, $align, @links, @color, @style);
 $align = '';
diff --git a/httemplate/search/report_cust_credit.html b/httemplate/search/report_cust_credit.html
index 05282e3be..f7d38801b 100644
--- a/httemplate/search/report_cust_credit.html
+++ b/httemplate/search/report_cust_credit.html
@@ -24,8 +24,10 @@
                 'field' => 'amount',
   &>
 
-  <& /elements/tr-select-show_voided_credits.html,
-                'label' => emt('Show Voided Credits'),
+  <& /elements/tr-checkbox.html,
+       'label' => emt('Show Voided Credits').':',
+       'field' => 'show_voided_credits',
+       'value' => '1',
   &>
 
 
@@ -51,4 +53,3 @@ my $title = $cgi->param('unapplied') ?
               'Unapplied credit report' : 'Credit report';
 
 </%init>
-