From: ivan <ivan>
Date: Mon, 18 Jan 1999 21:58:10 +0000 (+0000)
Subject: esthetic: eq and ne were used in a few places instead of == and !=
X-Git-Tag: freeside_1_2_0~79
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=a99792ee88e249c27c661a4ece2b4fa241f59e76

esthetic: eq and ne were used in a few places instead of == and !=
---

diff --git a/site_perl/cust_bill.pm b/site_perl/cust_bill.pm
index 3706aa4bf..5de1d929b 100644
--- a/site_perl/cust_bill.pm
+++ b/site_perl/cust_bill.pm
@@ -130,9 +130,10 @@ calling the collect method of a customer object (see L<FS::cust_main>).
 
 sub replace {
   my( $new, $old ) = ( shift, shift );
-  return "Can't change custnum!" unless $old->custnum eq $new->custnum;
-  return "Can't change _date!" unless $old->_date eq $new->_date;
-  return "Can't change charged!" unless $old->charged eq $new->charged;
+  return "Can't change custnum!" unless $old->custnum == $new->custnum;
+  #return "Can't change _date!" unless $old->_date eq $new->_date;
+  return "Can't change _date!" unless $old->_date == $new->_date;
+  return "Can't change charged!" unless $old->charged == $new->charged;
   return "(New) owed can't be > (new) charged!" if $new->owed > $new->charged;
 
   $new->SUPER::replace($old);
@@ -436,7 +437,7 @@ $address[4],''
 
 =head1 VERSION
 
-$Id: cust_bill.pm,v 1.4 1998-12-29 11:59:36 ivan Exp $
+$Id: cust_bill.pm,v 1.5 1999-01-18 21:58:03 ivan Exp $
 
 =head1 BUGS
 
@@ -469,7 +470,10 @@ charges can be negative ivan@sisd.com 98-jul-13
 pod, ingegrate with FS::Invoice ivan@sisd.com 98-sep-20
 
 $Log: cust_bill.pm,v $
-Revision 1.4  1998-12-29 11:59:36  ivan
+Revision 1.5  1999-01-18 21:58:03  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.4  1998/12/29 11:59:36  ivan
 mostly properly OO, some work still to be done with svc_ stuff
 
 Revision 1.3  1998/11/13 09:56:53  ivan
diff --git a/site_perl/cust_credit.pm b/site_perl/cust_credit.pm
index 321c01b34..a050e3021 100644
--- a/site_perl/cust_credit.pm
+++ b/site_perl/cust_credit.pm
@@ -107,9 +107,10 @@ inserting a refund (see L<FS::cust_refund>).
 sub replace {
   my ( $new, $old ) = ( shift, shift );
 
-  return "Can't change custnum!" unless $old->custnum eq $new->custnum;
-  return "Can't change date!" unless $old->_date eq $new->_date;
-  return "Can't change amount!" unless $old->amount eq $new->amount;
+  return "Can't change custnum!" unless $old->custnum == $new->custnum;
+  #return "Can't change date!" unless $old->_date eq $new->_date;
+  return "Can't change date!" unless $old->_date == $new->_date;
+  return "Can't change amount!" unless $old->amount == $new->amount;
   return "(New) credited can't be > (new) amount!"
     if $new->credited > $new->amount;
 
@@ -151,7 +152,7 @@ sub check {
 
 =head1 VERSION
 
-$Id: cust_credit.pm,v 1.2 1998-12-29 11:59:38 ivan Exp $
+$Id: cust_credit.pm,v 1.3 1999-01-18 21:58:04 ivan Exp $
 
 =head1 BUGS
 
@@ -169,7 +170,10 @@ ivan@sisd.com 98-mar-17
 pod, otaker from FS::UID ivan@sisd.com 98-sep-21
 
 $Log: cust_credit.pm,v $
-Revision 1.2  1998-12-29 11:59:38  ivan
+Revision 1.3  1999-01-18 21:58:04  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.2  1998/12/29 11:59:38  ivan
 mostly properly OO, some work still to be done with svc_ stuff
 
 
diff --git a/site_perl/cust_main_invoice.pm b/site_perl/cust_main_invoice.pm
index 61edae961..6ae6425ef 100644
--- a/site_perl/cust_main_invoice.pm
+++ b/site_perl/cust_main_invoice.pm
@@ -86,7 +86,7 @@ returns the error, otherwise returns false.
 sub replace {
   my ( $new, $old ) = ( shift, shift );
 
-  return "Can't change custnum!" unless $old->custnum eq $new->custnum;
+  return "Can't change custnum!" unless $old->custnum == $new->custnum;
 
   $new->SUPER::replace;
 }
@@ -152,7 +152,7 @@ sub address {
 
 =head1 VERSION
 
-$Id: cust_main_invoice.pm,v 1.4 1999-01-18 09:22:42 ivan Exp $
+$Id: cust_main_invoice.pm,v 1.5 1999-01-18 21:58:05 ivan Exp $
 
 =head1 BUGS
 
@@ -168,7 +168,10 @@ added hfields
 ivan@sisd.com 97-nov-13
 
 $Log: cust_main_invoice.pm,v $
-Revision 1.4  1999-01-18 09:22:42  ivan
+Revision 1.5  1999-01-18 21:58:05  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.4  1999/01/18 09:22:42  ivan
 changes to track email addresses for email invoicing
 
 Revision 1.3  1998/12/29 11:59:42  ivan
diff --git a/site_perl/cust_pkg.pm b/site_perl/cust_pkg.pm
index 66193510e..5b119ed28 100644
--- a/site_perl/cust_pkg.pm
+++ b/site_perl/cust_pkg.pm
@@ -129,7 +129,7 @@ in some cases).
 sub replace {
   my( $new, $old ) = ( shift, shift );
 
-  #return "Can't (yet?) change pkgpart!" if $old->pkgpart ne $new->pkgpart;
+  #return "Can't (yet?) change pkgpart!" if $old->pkgpart != $new->pkgpart;
   return "Can't change otaker!" if $old->otaker ne $new->otaker;
   return "Can't change setup once it exists!"
     if $old->getfield('setup') &&
@@ -459,7 +459,7 @@ sub order {
 
 =head1 VERSION
 
-$Id: cust_pkg.pm,v 1.4 1998-12-29 11:59:45 ivan Exp $
+$Id: cust_pkg.pm,v 1.5 1999-01-18 21:58:07 ivan Exp $
 
 =head1 BUGS
 
@@ -490,7 +490,10 @@ fixed for new agent->agent_type->type_pkgs in &order ivan@sisd.com 98-mar-7
 pod ivan@sisd.com 98-sep-21
 
 $Log: cust_pkg.pm,v $
-Revision 1.4  1998-12-29 11:59:45  ivan
+Revision 1.5  1999-01-18 21:58:07  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.4  1998/12/29 11:59:45  ivan
 mostly properly OO, some work still to be done with svc_ stuff
 
 Revision 1.3  1998/11/15 13:01:35  ivan
diff --git a/site_perl/pkg_svc.pm b/site_perl/pkg_svc.pm
index 9db0a12da..ee4ad629e 100644
--- a/site_perl/pkg_svc.pm
+++ b/site_perl/pkg_svc.pm
@@ -74,8 +74,8 @@ returns the error, otherwise returns false.
 sub replace {
   my ( $new, $old ) = ( shift, shift );
 
-  return "Can't change pkgpart!" if $old->pkgpart ne $new->pkgpart;
-  return "Can't change svcpart!" if $old->svcpart ne $new->svcpart;
+  return "Can't change pkgpart!" if $old->pkgpart != $new->pkgpart;
+  return "Can't change svcpart!" if $old->svcpart != $new->svcpart;
 
   $new->SUPER::replace($old);
 }
@@ -112,7 +112,7 @@ sub check {
 
 =head1 VERSION
 
-$Id: pkg_svc.pm,v 1.2 1998-12-29 11:59:51 ivan Exp $
+$Id: pkg_svc.pm,v 1.3 1999-01-18 21:58:08 ivan Exp $
 
 =head1 BUGS
 
@@ -131,7 +131,10 @@ ivan@sisd.com 97-nov-13
 pod ivan@sisd.com 98-sep-22
 
 $Log: pkg_svc.pm,v $
-Revision 1.2  1998-12-29 11:59:51  ivan
+Revision 1.3  1999-01-18 21:58:08  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.2  1998/12/29 11:59:51  ivan
 mostly properly OO, some work still to be done with svc_ stuff
 
 
diff --git a/site_perl/svc_acct.pm b/site_perl/svc_acct.pm
index 473f78b24..c69f1032b 100644
--- a/site_perl/svc_acct.pm
+++ b/site_perl/svc_acct.pm
@@ -232,7 +232,7 @@ sub replace {
     if $old->username ne $new->username &&
       qsearchs( 'svc_acct', { 'username' => $new->username } );
 
-  return "Can't change uid!" if $old->uid ne $new->uid;
+  return "Can't change uid!" if $old->uid != $new->uid;
 
   #change homdir when we change username
   $new->setfield('dir', '') if $old->username ne $new->username;
@@ -440,7 +440,7 @@ sub check {
 
 =head1 VERSION
 
-$Id: svc_acct.pm,v 1.4 1998-12-30 00:30:45 ivan Exp $
+$Id: svc_acct.pm,v 1.5 1999-01-18 21:58:09 ivan Exp $
 
 =head1 BUGS
 
@@ -482,7 +482,10 @@ arbitrary radius attributes ivan@sisd.com 98-aug-13
 pod and FS::conf ivan@sisd.com 98-sep-22
 
 $Log: svc_acct.pm,v $
-Revision 1.4  1998-12-30 00:30:45  ivan
+Revision 1.5  1999-01-18 21:58:09  ivan
+esthetic: eq and ne were used in a few places instead of == and !=
+
+Revision 1.4  1998/12/30 00:30:45  ivan
 svc_ stuff is more properly OO - has a common superclass FS::svc_Common
 
 Revision 1.2  1998/11/13 09:56:55  ivan
diff --git a/site_perl/svc_acct_sm.pm b/site_perl/svc_acct_sm.pm
index 75e7b0281..5c0f510e4 100644
--- a/site_perl/svc_acct_sm.pm
+++ b/site_perl/svc_acct_sm.pm
@@ -157,7 +157,7 @@ sub replace {
 
   return "Domain username (domuser) in use for this domain (domsvc)"
     if ( $old->domuser ne $new->domuser
-         || $old->domsvc  ne $new->domsvc
+         || $old->domsvc != $new->domsvc
        )  && qsearchs('svc_acct_sm',{
          'domuser'=> $new->domuser,
          'domsvc' => $new->domsvc,
@@ -229,7 +229,7 @@ sub check {
 
 =head1 VERSION
 
-$Id: svc_acct_sm.pm,v 1.4 1998-12-30 00:30:46 ivan Exp $
+$Id: svc_acct_sm.pm,v 1.5 1999-01-18 21:58:10 ivan Exp $
 
 =head1 BUGS