From: Ivan Kohler <ivan@freeside.biz>
Date: Thu, 20 Dec 2012 20:06:13 +0000 (-0800)
Subject: fix "Use of implicit split to @_ is deprecated" warning, RT#20731, RT#20706
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=825e0f0fdb1fb45c8b9523e795da816773f04295

fix "Use of implicit split to @_ is deprecated" warning, RT#20731, RT#20706
---

diff --git a/FS/FS/part_pkg/voip_cdr.pm b/FS/FS/part_pkg/voip_cdr.pm
index 84b00e99d..aae51e96c 100644
--- a/FS/FS/part_pkg/voip_cdr.pm
+++ b/FS/FS/part_pkg/voip_cdr.pm
@@ -481,8 +481,8 @@ sub check_chargable {
 
   return "carrierid NOT IN ( ". $self->option_cacheable('use_carrierid'). " )"
     if $self->option_cacheable('use_carrierid') =~ /\S/
-    && !grep { $cdr->carrierid eq $_ } split(/\s*,\s*/, $self->option_cacheable('use_carrierid')) #eq otherwise 0 matches ''
-    && ! $flags{'da_rewrote'};
+    && ! $flags{'da_rewrote'} #why?
+    && !grep { $cdr->carrierid eq $_ } split(/\s*,\s*/, $self->option_cacheable('use_carrierid')); #eq otherwise 0 matches ''
 
   # unlike everything else, use_cdrtypenum is applied in FS::svc_x::get_cdrs.
   return "cdrtypenum != ". $self->option_cacheable('use_cdrtypenum')