From: ivan <ivan>
Date: Wed, 1 Aug 2007 19:19:54 +0000 (+0000)
Subject: better error reporting: all three of these methods might return an error
X-Git-Tag: TRIXBOX_2_6~444
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=673d0068c5121d3eeb08d8643cf9432cdacdcf88

better error reporting: all three of these methods might return an error
---

diff --git a/FS/FS/ClientAPI/MyAccount.pm b/FS/FS/ClientAPI/MyAccount.pm
index 9ee770b20..bea31c5ac 100644
--- a/FS/FS/ClientAPI/MyAccount.pm
+++ b/FS/FS/ClientAPI/MyAccount.pm
@@ -910,10 +910,9 @@ sub _do_bop_realtime {
 
     my $old_balance = $cust_main->balance;
 
-    my $bill_error = $cust_main->bill;
-
-    $cust_main->apply_payments_and_credits;
-    $bill_error = $cust_main->collect('realtime' => 1);
+    my $bill_error =    $cust_main->bill
+                     || $cust_main->apply_payments_and_credits
+                     || $cust_main->collect('realtime' => 1);
 
     if (    $cust_main->balance > $old_balance
          && $cust_main->balance > 0