From: jeff <jeff>
Date: Wed, 22 Sep 2010 06:36:20 +0000 (+0000)
Subject: avoid unexpected side effects when using 'op' => '>' in qsearch
X-Git-Tag: TORRUS_1_0_9~284
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=60ee9af0e885def0dd61f4a5506ac0e55d779e89

avoid unexpected side effects when using 'op' => '>' in qsearch
---

diff --git a/FS/FS/Record.pm b/FS/FS/Record.pm
index 6b05d2dac..4f0984c74 100644
--- a/FS/FS/Record.pm
+++ b/FS/FS/Record.pm
@@ -350,7 +350,8 @@ sub qsearch {
   my @bind_type = ();
   my $dbh = dbh;
   foreach my $stable ( @stable ) {
-    my $record      = shift @record;
+    #stop altering the caller's hashref
+    my $record      = { %{ shift(@record) || {} } };#and be liberal in receipt
     my $select      = shift @select;
     my $extra_sql   = shift @extra_sql;
     my $extra_param = shift @extra_param;