From: Ivan Kohler <ivan@freeside.biz>
Date: Fri, 26 Jul 2019 18:35:08 +0000 (-0700)
Subject: clarify interface difference between calc_setup and calc_recur: calc_setup takes... 
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=4d32fe65cf99b766886fdfad4d8d3c7a3537bbc1

clarify interface difference between calc_setup and calc_recur: calc_setup takes a start time, calc_recur takes a start time scalar reference, RT#83503
---

diff --git a/FS/FS/part_pkg/flat_introrate.pm b/FS/FS/part_pkg/flat_introrate.pm
index f12b1accd..4c9abebc9 100644
--- a/FS/FS/part_pkg/flat_introrate.pm
+++ b/FS/FS/part_pkg/flat_introrate.pm
@@ -73,15 +73,15 @@ sub intro_end {
 }
 
 sub base_recur {
-  my($self, $cust_pkg, $time ) = @_;
+  my($self, $cust_pkg, $sdate ) = @_;
 
   my $now;
-  if (!$time) { # the "$sdate" from _make_lines
+  if (!$sdate) { # the "$sdate" from _make_lines
     my $log = FS::Log->new('FS::part_pkg');
     $log->warning("flat_introrate base_recur requires date!");
     $now = time;
   } else {
-    $now = $$time;
+    $now = $$sdate;
   }
 
   if ($now < $self->intro_end($cust_pkg)) {