From: ivan <ivan>
Date: Thu, 13 Mar 2008 09:28:44 +0000 (+0000)
Subject: yow.  very sleep deprived.  remove the infinite loop rather than add one.
X-Git-Tag: TRIXBOX_2_6~23
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=3b4f265c6d5233ca15eb21e8989a165a9ae32073

yow.  very sleep deprived.  remove the infinite loop rather than add one.
---

diff --git a/FS/FS/cust_pay.pm b/FS/FS/cust_pay.pm
index 0507276f4..358dfdc3d 100644
--- a/FS/FS/cust_pay.pm
+++ b/FS/FS/cust_pay.pm
@@ -687,19 +687,15 @@ sub _upgrade_data {  #class method
 
   my $count = 0;
   my $lastprog = 0;
-  my %seen = ();
-  while (1) {
 
-    my $cust_pay = qsearchs( {
+  my @cust_pay = qsearch( {
       'table'     => 'cust_pay',
       'hashref'   => {},
       'extra_sql' => $where,
-      'order_by'  => 'ORDER BY paynum LIMIT 1',
-    } );
-
-    return unless $cust_pay;
+      'order_by'  => 'ORDER BY paynum',
+  } );
 
-    next if $seen{$cust_pay->paynum}++;
+  foreach my $cust_pay (@cust_pay) {
 
     my $h_cust_pay = $cust_pay->h_search('insert');
     if ( $h_cust_pay ) {