From: Jonathan Prykop <jonathan@freeside.biz>
Date: Wed, 28 Oct 2015 00:09:07 +0000 (-0500)
Subject: RT#38671: Do not include charges and credits from failed signup processing [deprecate... 
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=39886919a332d3cd4b8a3d9ad9b7a9f14d0576a0

RT#38671: Do not include charges and credits from failed signup processing [deprecated signup_credit_type]
---

diff --git a/FS/FS/Conf.pm b/FS/FS/Conf.pm
index 594c0e076..990f2a3be 100644
--- a/FS/FS/Conf.pm
+++ b/FS/FS/Conf.pm
@@ -4176,9 +4176,10 @@ and customer address. Include units.',
     reason_type_options('R'),
   },
 
+  # was only used to negate invoices during signup when card was declined, now we just void
   {
     'key'         => 'signup_credit_type',
-    'section'     => 'billing', #self-service?
+    'section'     => 'deprecated', #self-service?
     'description' => 'The group to use for new, automatically generated credit reasons resulting from signup and self-service declines.',
     reason_type_options('R'),
   },
diff --git a/FS/FS/cust_credit.pm b/FS/FS/cust_credit.pm
index 31adebec1..2f2338ee4 100644
--- a/FS/FS/cust_credit.pm
+++ b/FS/FS/cust_credit.pm
@@ -40,7 +40,6 @@ $FS::UID::callback{'FS::cust_credit'} = sub {
 
 our %reasontype_map = ( 'referral_credit_type' => 'Referral Credit',
                         'cancel_credit_type'   => 'Cancellation Credit',
-                        'signup_credit_type'   => 'Self-Service Credit',
                       );
 
 =head1 NAME