From: ivan <ivan>
Date: Sun, 5 Sep 2004 09:41:35 +0000 (+0000)
Subject: acquire a database lock to prevent race conditions in duplicate checking
X-Git-Tag: freeside_1_4_2beta1~36
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=1555a620f8f05ba8f3bccba6ec5f559752bbef5d

acquire a database lock to prevent race conditions in duplicate checking
---

diff --git a/FS/FS/svc_acct.pm b/FS/FS/svc_acct.pm
index 806e793ea..da3571e62 100644
--- a/FS/FS/svc_acct.pm
+++ b/FS/FS/svc_acct.pm
@@ -251,6 +251,13 @@ sub insert {
 
   #new duplicate username/username@domain/uid checking
 
+  #this is Pg-specific.  what to do for mysql etc?
+  # ( mysql LOCK TABLES certainly isn't equivalent or useful here :/ )
+  warn "$me locking svc_acct table for duplicate search" if $DEBUG;
+  dbh->do("LOCK TABLE svc_acct IN SHARE ROW EXCLUSIVE MODE")
+    or die dbh->errstr;
+  warn "$me acquired svc_acct table lock for duplicate search" if $DEBUG;
+
   my $part_svc = qsearchs('part_svc', { 'svcpart' => $self->svcpart } );
   unless ( $part_svc ) {
     $dbh->rollback if $oldAutoCommit;