From: ivan Date: Wed, 9 Jul 2008 20:37:14 +0000 (+0000) Subject: should avoid spurious uninitialized value warnings on upgrade X-Git-Tag: root_of_webpay_support~490 X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=13a2fbbfbff2e8cc3cfa26a51e8bdbd39d4b0c2e should avoid spurious uninitialized value warnings on upgrade --- diff --git a/FS/FS/part_pkg.pm b/FS/FS/part_pkg.pm index 7bb434dbe..0b2c53d1b 100644 --- a/FS/FS/part_pkg.pm +++ b/FS/FS/part_pkg.pm @@ -342,7 +342,13 @@ sub replace { my $pkg_svc = $options->{'pkg_svc'} || {}; foreach my $part_svc ( qsearch('part_svc', {} ) ) { my $quantity = $pkg_svc->{$part_svc->svcpart} || 0; - my $primary_svc = $options->{'primary_svc'} == $part_svc->svcpart ? 'Y' : ''; + my $primary_svc = + ( defined($options->{'primary_svc'}) + && $options->{'primary_svc'} == $part_svc->svcpart + ) + ? 'Y' + : ''; + my $old_pkg_svc = qsearchs('pkg_svc', { 'pkgpart' => $old->pkgpart,