From: Christopher Burger <burgerc@freeside.biz>
Date: Tue, 1 Aug 2017 17:53:42 +0000 (-0400)
Subject: RT # 73490 - removed global conf and user pref check for hide tickets and added group... 
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=0868e3d3883695b4acf8fbb0c61a08f2249af389

RT # 73490 - removed global conf and user pref check for hide tickets and added group access control.
---

diff --git a/FS/FS/AccessRight.pm b/FS/FS/AccessRight.pm
index ededf9efd..40b5b37c6 100644
--- a/FS/FS/AccessRight.pm
+++ b/FS/FS/AccessRight.pm
@@ -362,6 +362,10 @@ tie my %rights, 'Tie::IxHash',
     { rightname=>'Employee preference telephony integration' },
   #]
 
+  #'RT preference rights' => [
+    { rightname=>'not an RT' },
+  #]
+
   ],
   
   ###
diff --git a/FS/FS/Conf.pm b/FS/FS/Conf.pm
index 967468b39..77add5d97 100644
--- a/FS/FS/Conf.pm
+++ b/FS/FS/Conf.pm
@@ -5619,13 +5619,6 @@ and customer address. Include units.',
   },
 
   {
-    'key'         => 'rt-hide_activity_notification',
-    'section'     => 'ticketing',
-    'description' => 'Hide the notification box when there is activity on tickets',
-    'type'        => 'checkbox',
-  },
-
-  {
     'key'         => 'pkg-balances',
     'section'     => 'billing',
     'description' => 'Enable per-package balances.',
diff --git a/httemplate/elements/notify-tickets.html b/httemplate/elements/notify-tickets.html
index 0c370744b..aebbef669 100644
--- a/httemplate/elements/notify-tickets.html
+++ b/httemplate/elements/notify-tickets.html
@@ -13,12 +13,8 @@
 <%init>
 use Class::Load 'load_class';
 
-use FS::Conf;
-my $conf = new FS::Conf;
-
 my $enabled = $FS::TicketSystem::system eq 'RT_Internal';
-$enabled = 0 if $FS::CurrentUser::CurrentUser->option('hide_notify_tickets');
-$enabled = 0 if $conf->exists('rt-hide_activity_notification');
+$enabled = 0 if $FS::CurrentUser::CurrentUser->access_right('not an RT');
 my $UnrepliedTickets;
 if ($enabled) {
   my $class = 'RT::Search::UnrepliedTickets';
diff --git a/httemplate/pref/pref-process.html b/httemplate/pref/pref-process.html
index 0134e6a9b..f5b5bb68e 100644
--- a/httemplate/pref/pref-process.html
+++ b/httemplate/pref/pref-process.html
@@ -56,7 +56,6 @@ unless ( $error ) { # if ($access_user) {
                       enable_mask_clipboard_hack dashboard_customers
                       customer_view_emails
                       printtofit
-                      hide_notify_tickets
                       email_address
                       snom-ip snom-username snom-password
                       vonage-fromnumber vonage-username vonage-password
diff --git a/httemplate/pref/pref.html b/httemplate/pref/pref.html
index bf0cc90a7..d976871f5 100644
--- a/httemplate/pref/pref.html
+++ b/httemplate/pref/pref.html
@@ -150,13 +150,6 @@ Interface
   </TR>
 
   <TR>
-    <TH ALIGN="right"><% emt('Hide notification of new ticket activity') %></TH>
-    <TD ALIGN="left">
-      <INPUT TYPE="checkbox" NAME="hide_notify_tickets" VALUE="1" <% $curuser->option('hide_notify_tickets') ? 'CHECKED' : '' %>>
-    </TD>
-  </TR>
-
-  <TR>
     <TH ALIGN="right"><% emt("How many recently-modified customers displayed on dashboard") %></TH>
     <TD ALIGN="left" COLSPAN=2>
       <INPUT TYPE="text" NAME="dashboard_customers" VALUE="<% $curuser->option('dashboard_customers') %>"></TD>