From: ivan <ivan>
Date: Mon, 23 Dec 2002 23:56:26 +0000 (+0000)
Subject: remove gratuitous warning and better error messages
X-Git-Tag: freeside_1_5_0pre1~67
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=022f47d636bcec1699a0e8ebce394f5756af5f8c;hp=1014e988be16a7158ff7ca0d0a6e7aac730517a0

remove gratuitous warning and better error messages
---

diff --git a/FS/FS/svc_acct.pm b/FS/FS/svc_acct.pm
index 659835626..456c965af 100644
--- a/FS/FS/svc_acct.pm
+++ b/FS/FS/svc_acct.pm
@@ -366,7 +366,6 @@ sub insert {
           'svcnum' => $self->svcnum,
           'job'    => 'FS::svc_acct::send_email'
         };
-        warn "attempting to queue email to $to";
         my $error = $wqueue->insert(
           'to'       => $to,
           'from'     => $welcome_from,
@@ -383,14 +382,14 @@ sub insert {
         );
         if ( $error ) {
           $dbh->rollback if $oldAutoCommit;
-          return "queuing welcome email: $error";
+          return "error queuing welcome email: $error";
         }
 
         foreach my $jobnum ( @jobnums ) {
           my $error = $wqueue->depend_insert($jobnum);
           if ( $error ) {
             $dbh->rollback if $oldAutoCommit;
-            return "queuing welcome email job dependancy: $error";
+            return "error queuing welcome email job dependancy: $error";
           }
         }