is this broken or is the calculation?

diff --git a/FS/bin/freeside-sqlradius-seconds b/FS/bin/freeside-sqlradius-seconds
index d2358cd..0539cb4 100644 (file)
--- a/FS/bin/freeside-sqlradius-seconds
+++ b/FS/bin/freeside-sqlradius-seconds
@@ -10,16 +10,13 @@ my $fs_user = shift or die &usage;
 adminsuidsetup( $fs_user );
 
 my $target_user = shift or die &usage;
-my $start = shift or die &usage;
-my $stop = scalar(@_) ? shift : '';
+my $start = scalar(@_) && str2time(shift) or die &usage;
+my $stop =  scalar(@_) ?  str2time(shift) :  time;
 
 my $svc_acct = qsearchs( 'svc_acct', { 'username' => $target_user } );
 die "username $target_user not found\n" unless $svc_acct;
 
-print $svc_acct->seconds_since_sqlradacct(
-                                           str2time($start),
-                                           $stop ? str2time($stop) : time  ).
-      "\n";
+print $svc_acct->seconds_since_sqlradacct( $start, $stop ). "\n";
 
 sub usage {
   die "Usage:\n\n  freeside-sqlradius-seconds freeside_username target_username start_date stop_date\n";