better error reporting: all three of these methods might return an error
authorivan <ivan>
Wed, 1 Aug 2007 19:19:54 +0000 (19:19 +0000)
committerivan <ivan>
Wed, 1 Aug 2007 19:19:54 +0000 (19:19 +0000)
FS/FS/ClientAPI/MyAccount.pm

index 9ee770b..bea31c5 100644 (file)
@@ -910,10 +910,9 @@ sub _do_bop_realtime {
 
     my $old_balance = $cust_main->balance;
 
-    my $bill_error = $cust_main->bill;
-
-    $cust_main->apply_payments_and_credits;
-    $bill_error = $cust_main->collect('realtime' => 1);
+    my $bill_error =    $cust_main->bill
+                     || $cust_main->apply_payments_and_credits
+                     || $cust_main->collect('realtime' => 1);
 
     if (    $cust_main->balance > $old_balance
          && $cust_main->balance > 0