service dependencies: cust_svc_suspend_cascade, RT#33685

diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index 9352362..5859727 100644 (file)
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -1404,7 +1404,7 @@ sub suspend {
       }
     }
 
-    my @cust_svc = qsearch( 'cust_svc', { 'pkgnum' => $self->pkgnum } )
+    my @cust_svc = qsearch( 'cust_svc', { 'pkgnum' => $self->pkgnum } );
 
     #attempt ordering ala cust_svc_suspend_cascade (without infinite-looping
     # on the circular dep case)
@@ -1413,7 +1413,7 @@ sub suspend {
     my %svcpart = ();
     $svcpart{$_->svcpart} = 0 foreach @cust_svc;
     foreach my $svcpart ( keys %svcpart ) {
-      foreach my $part_pkg_link (
+      foreach my $part_svc_link (
         FS::part_svc_link->by_agentnum($self->cust_main->agentnum,
                                          src_svcpart => $svcpart,
                                          link_type => 'cust_svc_suspend_cascade'

diff --git a/FS/FS/cust_svc.pm b/FS/FS/cust_svc.pm
index 0465580..986c5ae 100644 (file)
--- a/FS/FS/cust_svc.pm
+++ b/FS/FS/cust_svc.pm
@@ -202,7 +202,7 @@ sub suspend {
   my $svc = qsearchs( $svcdb, { 'svcnum' => $self->svcnum } )
     or return '';
 
-  $error = $svc->suspend;
+  my $error = $svc->suspend;
   return $error if $error;
 
   if ( $opt{labels_arryref} ) {