X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=rt%2Flib%2FRT%2FTransactions.pm;h=6794e527fac9d09621a514e52beedf3631cb2deb;hp=82bd50f124bb4e69ffac94f51015e83226c74ae0;hb=9aee669886202be7035e6c6049fc71bc99dd3013;hpb=45d35d5739d05e602bc317739485693e0e9ff0b5 diff --git a/rt/lib/RT/Transactions.pm b/rt/lib/RT/Transactions.pm index 82bd50f12..6794e527f 100755 --- a/rt/lib/RT/Transactions.pm +++ b/rt/lib/RT/Transactions.pm @@ -2,7 +2,7 @@ # # COPYRIGHT: # -# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC +# This software is Copyright (c) 1996-2015 Best Practical Solutions, LLC # # # (Except where explicitly superseded by other copyright notices) @@ -69,11 +69,10 @@ package RT::Transactions; use strict; use warnings; +use base 'RT::SearchBuilder'; use RT::Transaction; -use base 'RT::SearchBuilder'; - sub Table { 'Transactions'} # {{{ sub _Init @@ -85,9 +84,9 @@ sub _Init { # By default, order by the date of the transaction, rather than ID. $self->OrderByCols( { FIELD => 'Created', - ORDER => 'ASC' }, - { FIELD => 'id', - ORDER => 'ASC' } ); + ORDER => 'ASC' }, + { FIELD => 'id', + ORDER => 'ASC' } ); return ( $self->SUPER::_Init(@_)); } @@ -109,11 +108,10 @@ sub LimitToTicket { my $tid = shift; unless ( $self->{'tickets_table'} ) { - $self->{'tickets_table'} ||= $self->NewAlias('Tickets'); - $self->Join( + $self->{'tickets_table'} ||= $self->Join( ALIAS1 => 'main', FIELD1 => 'ObjectId', - ALIAS2 => $self->{'tickets_table'}, + TABLE2 => 'Tickets', FIELD2 => 'id' ); $self->Limit( @@ -132,43 +130,14 @@ sub LimitToTicket { } -sub Next { +sub AddRecord { my $self = shift; - - my $Transaction = $self->SUPER::Next(); - if ((defined($Transaction)) and (ref($Transaction))) { - # If the user can see the transaction's type, then they can - # see the transaction and we should hand it back. - if ($Transaction->Type) { - return($Transaction); - } - - #If the user doesn't have the right to show this ticket - else { - return($self->Next()); - } - } + my ($record) = @_; - #if there never was any ticket - else { - return(undef); - } + return unless $record->CurrentUserCanSee; + return $self->SUPER::AddRecord($record); } - - - - -=head2 NewItem - -Returns an empty new RT::Transaction item - -=cut - -sub NewItem { - my $self = shift; - return(RT::Transaction->new($self->CurrentUser)); -} RT::Base->_ImportOverlays(); 1;