X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=rt%2F.perlcriticrc;h=14246309a114ed9e17541d14652fc692ad38d797;hp=9cf8f633f8cddbca1090dfd90163514d8640ef3c;hb=681a340f6be4184b1472a8e1fa9cd5d074f6f325;hpb=a6fe07e49e3fc12169e801b1ed6874c3a5bd8500

diff --git a/rt/.perlcriticrc b/rt/.perlcriticrc
index 9cf8f633f..14246309a 100644
--- a/rt/.perlcriticrc
+++ b/rt/.perlcriticrc
@@ -4,3 +4,23 @@
 exclude = Subroutines::ProhibitExplicitReturnUndef  Modules::RequireFilenameMatchesPackage TestingAndDebugging::ProhibitNoStrict
 color = 1
 verbose = 7
+
+
+# we don't unpack @_ right away as we mostly use named vars with defaults:
+# sub foo {
+#     my $self = shift;
+#     my %args = ( default => 'value', ..., @_ );
+# ...
+[-Subroutines::RequireArgUnpacking]
+
+# Readonly superiority is not convincing, especially considering
+# that 'use constant' participates in constants folding during
+# compilation
+[-ValuesAndExpressions::ProhibitConstantPragma]
+
+# brutal
+[BuiltinFunctions::RequireBlockGrep]
+severity = 1
+
+[BuiltinFunctions::RequireBlockMap]
+severity = 1