X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=httemplate%2Fsearch%2Fcust_credit_bill_pkg.html;h=fef295e621898dcc72e9792d285ec6025cd3c0ea;hp=d20462dea5913658cb119b45e0074402501aeb6e;hb=bbe932f2b25d9b031ef51fcb55a9c667986d0a84;hpb=38919d1e68a62afea9cc9ae23b28957ea7a7987d

diff --git a/httemplate/search/cust_credit_bill_pkg.html b/httemplate/search/cust_credit_bill_pkg.html
index d20462dea..fef295e62 100644
--- a/httemplate/search/cust_credit_bill_pkg.html
+++ b/httemplate/search/cust_credit_bill_pkg.html
@@ -27,7 +27,7 @@
                    sub { sprintf($money_char.'%.2f', shift->amount ) },
 
                    sub { time2str('%b %d %Y', shift->get('cust_credit_date') ) },
-                   'otaker',
+                   sub { shift->cust_credit_bill->cust_credit->otaker },
                    sub { shift->cust_credit_bill->cust_credit->reason },
 
                    sub { $_[0]->pkgnum > 0
@@ -38,8 +38,16 @@
                    sub { time2str('%b %d %Y', shift->_date ) },
                    \&FS::UI::Web::cust_fields,
                  ],
-                 #'sort_fields' => [ #XXX add
-                 #],
+                 'sort_fields' => [
+                   'amount',
+                   'cust_credit_date',
+                   '', #'otaker',
+                   '', #reason
+                   '', #line item description
+                   'invnum',
+                   '_date',
+                   #cust fields
+                 ],
                  'links'       => [
                    '',
                    '',
@@ -256,7 +264,10 @@ if ( $cgi->param('out') ) {
     #warn "neither nottax nor istax parameters specified";
   }
 
-  if ( $cgi->param('taxclassNULL') ) {
+  if ( $cgi->param('taxclassNULL')
+       && ! $cgi->param('istax')  #no taxclass in this case
+     )
+  {
 
     my %hash = ( 'country' => scalar($cgi->param('country')) );
     foreach (qw( state county )) {
@@ -345,7 +356,7 @@ my $join_cust =
 
 my $join_pkg;
 
-my $join_cust_bill_pkg = 'LEFT JOIN cust_bill_pkg USING ( billpkgnum ';
+my $join_cust_bill_pkg = 'LEFT JOIN cust_bill_pkg USING ( billpkgnum )';
 
 if ( $cgi->param('nottax') ) {
 
@@ -363,20 +374,7 @@ if ( $cgi->param('nottax') ) {
             $cgi->param('iscredit') eq 'rate') {
 
     $join_pkg .=
-      ' LEFT JOIN cust_bill_pkg_tax_rate_location USING ( billpkgnum ) '.
-      ' LEFT JOIN tax_rate_location USING ( taxratelocationnum ) ';
-
-  } elsif ( $conf->exists('tax-pkg_address') ) {
-
-    $join_pkg .= ' LEFT JOIN cust_bill_pkg_tax_location USING ( billpkgnum )
-                   LEFT JOIN cust_location              USING ( locationnum ) ';
-
-    #quelle kludge, somewhat false laziness w/report_tax.cgi
-    s/cust_pkg\.locationnum/cust_bill_pkg_tax_location.locationnum/g for @where;
-  }
-
-  #if ( $cgi->param('iscredit') ) {
-    $join_pkg .= ' JOIN cust_credit_bill_pkg USING ( billpkgnum';
+      ' LEFT JOIN cust_bill_pkg_tax_rate_location USING ( billpkgnum ';
     if ( $cgi->param('iscredit') eq 'rate' ) {
       $join_pkg .= ', billpkgtaxratelocationnum )';
     } elsif ( $conf->exists('tax-pkg_address') ) {
@@ -386,7 +384,17 @@ if ( $cgi->param('nottax') ) {
       $join_pkg .= ' )';
       push @where, "billpkgtaxratelocationnum IS NULL";
     }
-  #}
+
+    $join_pkg .= ' LEFT JOIN tax_rate_location USING ( taxratelocationnum ) ';
+
+  } elsif ( $conf->exists('tax-pkg_address') ) {
+
+    $join_pkg .= ' LEFT JOIN cust_bill_pkg_tax_location USING ( billpkgnum )
+                   LEFT JOIN cust_location              USING ( locationnum ) ';
+
+    #quelle kludge, somewhat false laziness w/report_tax.cgi
+    s/cust_pkg\.locationnum/cust_bill_pkg_tax_location.locationnum/g for @where;
+  }
 
 } else {