X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fsvc_pbx.pm;h=37ab174d2193603c9f941bc7c3ab7c7eb3a592e7;hp=21aaa4e0b518fefc4962e232b975c8239b687731;hb=aed8ec35ccb9cdeb7ea0cb6ff2946f9d83d582f6;hpb=40d935c8cd952be7b461405406d9d03f46775baf diff --git a/FS/FS/svc_pbx.pm b/FS/FS/svc_pbx.pm index 21aaa4e0b..37ab174d2 100644 --- a/FS/FS/svc_pbx.pm +++ b/FS/FS/svc_pbx.pm @@ -3,6 +3,7 @@ package FS::svc_pbx; use strict; use base qw( FS::svc_External_Common ); use FS::Record qw( qsearch qsearchs dbh ); +use FS::Conf; use FS::cust_svc; use FS::svc_phone; use FS::svc_acct; @@ -80,8 +81,9 @@ sub table { 'svc_pbx'; } sub table_info { { 'name' => 'PBX', - 'name_plural' => 'PBXs', #optional, - 'longname_plural' => 'PBXs', #optional + 'name_plural' => 'PBXs', + 'lcname_plural' => 'PBXs', + 'longname_plural' => 'PBXs', 'sorts' => 'svcnum', # optional sort field (or arrayref of sort fields, main first) 'display_weight' => 70, 'cancel_weight' => 90, @@ -90,24 +92,6 @@ sub table_info { 'title' => 'Name', 'max_extensions' => 'Maximum number of User Extensions', 'max_simultaneous' => 'Maximum number of simultaneous users', -# 'field' => 'Description', -# 'another_field' => { -# 'label' => 'Description', -# 'def_label' => 'Description for service definitions', -# 'type' => 'text', -# 'disable_default' => 1, #disable switches -# 'disable_fixed' => 1, # -# 'disable_inventory' => 1, # -# }, -# 'foreign_key' => { -# 'label' => 'Description', -# 'def_label' => 'Description for service defs', -# 'type' => 'select', -# 'select_table' => 'foreign_table', -# 'select_key' => 'key_field_in_table', -# 'select_label' => 'label_field_in_table', -# }, - }, }; } @@ -252,19 +236,114 @@ sub check { $self->SUPER::check; } -#XXX this is a way-too simplistic implementation -# at the very least, title should be unique across exports that need that or -# controlled by a conf setting or something sub _check_duplicate { my $self = shift; + my $conf = new FS::Conf; + $self->lock_table; - if ( qsearchs( 'svc_pbx', { 'title' => $self->title } ) ) { - return "Name in use"; - } else { - return ''; + foreach my $field ('title', 'id') { + my $global_unique = $conf->config("global_unique-pbx_$field"); + # can be 'disabled', 'enabled', or empty. + # if empty, check per exports; if not empty or disabled, check + # globally. + next if $global_unique eq 'disabled'; + my @dup = $self->find_duplicates( + ($global_unique ? 'global' : 'export') , $field + ); + next if !@dup; + return "duplicate $field '".$self->getfield($field). + "': conflicts with svcnum ".$dup[0]->svcnum; + } + return ''; +} + +=item get_cdrs + +Returns a set of Call Detail Records (see L) associated with this +service. By default, "associated with" means that the "charged_party" field of +the CDR matches the "title" field of the service. + +=over 2 + +Accepts the following options: + +=item for_update => 1: SELECT the CDRs "FOR UPDATE". + +=item status => "" (or "done"): Return only CDRs with that processing status. + +=item inbound => 1: No-op for svc_pbx CDR processing. + +=item default_prefix => "XXX": Also accept the phone number of the service prepended +with the chosen prefix. + +=item disable_src => 1: No-op for svc_pbx CDR processing. + +=item by_svcnum => 1: Select CDRs where the svcnum field matches, instead of +title/charged_party. Normally this field is set after processing. + +=item begin, end: Start and end of date range, as unix timestamp. + +=item cdrtypenum: Only return CDRs with this type number. + +=back + +=cut + +sub get_cdrs { + my($self, %options) = @_; + my %hash = (); + my @where = (); + + my @fields = ( 'charged_party' ); + $hash{'freesidestatus'} = $options{'status'} + if exists($options{'status'}); + + if ($options{'cdrtypenum'}) { + $hash{'cdrtypenum'} = $options{'cdrtypenum'}; + } + + my $for_update = $options{'for_update'} ? 'FOR UPDATE' : ''; + + if ( $options{'by_svcnum'} ) { + $hash{'svcnum'} = $self->svcnum; + } + else { + #matching by title + my $title = $self->title; + + my $prefix = $options{'default_prefix'}; + + my @orwhere = map " $_ = '$title' ", @fields; + push @orwhere, map " $_ = '$prefix$title' ", @fields + if length($prefix); + if ( $prefix =~ /^\+(\d+)$/ ) { + push @orwhere, map " $_ = '$1$title' ", @fields + } + + push @where, ' ( '. join(' OR ', @orwhere ). ' ) '; + } + + if ( $options{'begin'} ) { + push @where, 'startdate >= '. $options{'begin'}; } + if ( $options{'end'} ) { + push @where, 'startdate < '. $options{'end'}; + } + + my $extra_sql = ( keys(%hash) ? ' AND ' : ' WHERE ' ). join(' AND ', @where ) + if @where; + + my @cdrs = + qsearch( { + 'table' => 'cdr', + 'hashref' => \%hash, + 'extra_sql' => $extra_sql, + 'order_by' => "ORDER BY startdate $for_update", + } ); + + @cdrs; } =back