X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fquotation.pm;h=a3f061291b4330dc404bc9cbc36255ffdce399ad;hp=930083e107ca1df98ebcaeaf7a73aa70638a99bb;hb=046409735189fe40a1d349c4f1902da2bc1d71b2;hpb=f27cc902969814f2c11a49ebaadccc9ca31cfe8d diff --git a/FS/FS/quotation.pm b/FS/FS/quotation.pm index 930083e10..a3f061291 100644 --- a/FS/FS/quotation.pm +++ b/FS/FS/quotation.pm @@ -14,8 +14,9 @@ use FS::cust_pkg; use FS::quotation_pkg; use FS::quotation_pkg_tax; use FS::type_pkgs; +use List::MoreUtils; -our $DEBUG = 1; +our $DEBUG = 0; use Data::Dumper; =head1 NAME @@ -68,6 +69,13 @@ disabled usernum +=item close_date + +projected date when the quotation will be closed + +=item confidence + +projected confidence (expressed as integer) that quotation will close =back @@ -87,6 +95,7 @@ points to. You can ask the object for a copy with the I method. sub table { 'quotation'; } sub notice_name { 'Quotation'; } sub template_conf { 'quotation_'; } +sub has_sections { 1; } =item insert @@ -120,6 +129,8 @@ sub check { || $self->ut_numbern('_date') || $self->ut_enum('disabled', [ '', 'Y' ]) || $self->ut_numbern('usernum') + || $self->ut_numbern('close_date') + || $self->ut_numbern('confidence') ; return $error if $error; @@ -127,6 +138,10 @@ sub check { $self->usernum($FS::CurrentUser::CurrentUser->usernum) unless $self->usernum; + return 'confidence percentage must be an integer between 1 and 100' + if length($self->confidence) + && ( ($self->confidence < 1) || ($self->confidence > 100) ); + return 'prospectnum or custnum must be specified' if ! $self->prospectnum && ! $self->custnum; @@ -152,7 +167,7 @@ sub cust_bill_pkg { #actually quotation_pkg objects sub total_setup { my $self = shift; - $self->_total('setup'); + sprintf('%.2f', $self->_total('setup') + $self->_total('setup_tax')); } =item total_recur [ FREQ ] @@ -163,14 +178,14 @@ sub total_recur { my $self = shift; #=item total_recur [ FREQ ] #my $freq = @_ ? shift : ''; - $self->_total('recur'); + sprintf('%.2f', $self->_total('recur') + $self->_total('recur_tax')); } sub _total { my( $self, $method ) = @_; my $total = 0; - $total += $_->$method() for $self->cust_bill_pkg; + $total += $_->$method() for $self->quotation_pkg; sprintf('%.2f', $total); } @@ -212,6 +227,11 @@ sub email_subject { eval qq("$subject"); } +sub pdf_filename { + my $self = shift; + 'Quotation-'. $self->quotationnum. '.pdf'; +} + =item cust_or_prosect =cut @@ -221,7 +241,7 @@ sub cust_or_prospect { $self->custnum ? $self->cust_main : $self->prospect_main; } -=item cust_or_prospect_label_link P +=item cust_or_prospect_label_link HTML links to either the customer or prospect. @@ -253,87 +273,101 @@ sub cust_or_prospect_label_link { } -sub _items_tax { - (); -} +sub _items_sections { + my $self = shift; + my %opt = @_; + my $escape = $opt{escape}; # the only one we care about -sub _items_nontax { - shift->cust_bill_pkg; -} -sub _items_total { - my $self = shift; - $self->quotationnum =~ /^(\d+)$/ or return (); + my %show; # package frequency => 1 if there's anything to display + my %subtotals = (); # package frequency => subtotal + my $prorate_total = 0; + foreach my $pkg ($self->quotation_pkg) { - my @items; + my $part_pkg = $pkg->part_pkg; - # show taxes in here also; the setup/recurring breakdown is different - # from what Template_Mixin expects - my @setup_tax = qsearch({ - select => 'itemdesc, SUM(setup_amount) as setup_amount', - table => 'quotation_pkg_tax', - addl_from => ' JOIN quotation_pkg USING (quotationpkgnum) ', - extra_sql => ' WHERE quotationnum = '.$1, - order_by => ' GROUP BY itemdesc HAVING SUM(setup_amount) > 0' . - ' ORDER BY itemdesc', - }); - # recurs need to be grouped by frequency, and to have a pkgpart - my @recur_tax = qsearch({ - select => 'freq, itemdesc, SUM(recur_amount) as recur_amount, MAX(pkgpart) as pkgpart', - table => 'quotation_pkg_tax', - addl_from => ' JOIN quotation_pkg USING (quotationpkgnum)'. - ' JOIN part_pkg USING (pkgpart)', - extra_sql => ' WHERE quotationnum = '.$1, - order_by => ' GROUP BY freq, itemdesc HAVING SUM(recur_amount) > 0' . - ' ORDER BY freq, itemdesc', - }); + my $recur_freq = $part_pkg->freq; + $show{$recur_freq} = 1 if $pkg->unitrecur > 0 or $pkg->recur_show_zero; + $show{0} = 1 if $pkg->unitsetup > 0 or $pkg->setup_show_zero; + ($subtotals{0} ||= 0) += $pkg->setup + $pkg->setup_tax; + ($subtotals{$recur_freq} ||= 0) += $pkg->recur + $pkg->recur_tax; + + #this is a shitty hack based on what's in part_pkg/ at the moment + # but its good enough for the 99% common case of preventing totals from + # displaying for prorate packages + $prorate_total = 1 + if $part_pkg->plan =~ /^(prorate|torrus|agent$)/ + || $part_pkg->option('recur_method') eq 'prorate' + || ( $part_pkg->option('sync_bill_date') + && $self->custnum + && $self->cust_main->billing_pkgs #num_billing_pkgs when we have it + ); + + #possible improvement: keep track of flat vs. prorate totals to make the + # bottom range more accurate when mixing flat and prorate packages - my $total_setup = $self->total_setup; - foreach my $pkg_tax (@setup_tax) { - if ($pkg_tax->setup_amount > 0) { - $total_setup += $pkg_tax->setup_amount; - push @items, { - 'total_item' => $pkg_tax->itemdesc . ' ' . $self->mt('(setup)'), - 'total_amount' => $pkg_tax->setup_amount, - }; - } } + my @pkg_freq_order = keys %{ FS::Misc->pkg_freqs }; + + my @sections; + my $no_recurring = 0; + foreach my $freq (keys %subtotals) { + + #next if $subtotals{$freq} == 0; + next if !$show{$freq}; + + my $weight = + List::MoreUtils::first_index { $_ eq $freq } @pkg_freq_order; + my $desc; + if ( $freq eq '0' ) { + if ( scalar(keys(%subtotals)) == 1 ) { + # there are no recurring packages + $no_recurring = 1; + $desc = $self->mt('Charges'); + } else { + $desc = $self->mt('Setup Charges'); + } + } else { # recurring + $desc = $self->mt('Recurring Charges') . ' - ' . + ucfirst($self->mt(FS::Misc->pkg_freqs->{$freq})) + } - if ( $total_setup > 0 ) { - push @items, { - 'total_item' => $self->mt( $self->total_recur > 0 ? 'Total Setup' : 'Total' ), - 'total_amount' => sprintf('%.2f',$total_setup), - 'break_after' => ( scalar(@recur_tax) ? 1 : 0 ) + push @sections, { + 'description' => &$escape($desc), + 'sort_weight' => $weight, + 'category' => $freq, + 'subtotal' => sprintf('%.2f',$subtotals{$freq}), }; } - #could/should add up the different recurring frequencies on lines of their own - # but this will cover the 95% cases for now - my $total_recur = $self->total_recur; - # label these with the frequency - foreach my $pkg_tax (@recur_tax) { - if ($pkg_tax->recur_amount > 0) { - $total_recur += $pkg_tax->recur_amount; - # an arbitrary part_pkg, but with the right frequency - # XXX localization - my $part_pkg = qsearchs('part_pkg', { pkgpart => $pkg_tax->pkgpart }); - push @items, { - 'total_item' => $pkg_tax->itemdesc . ' (' . $part_pkg->freq_pretty . ')', - 'total_amount' => $pkg_tax->recur_amount, + unless ( $no_recurring ) { + my $total = 0; + $total += $_ for values %subtotals; + my %total = ( + 'sort_weight' => 0, + 'category' => 'Total category', #required but what's it used for? + ); + + if ( $prorate_total ) { + + push @sections, { + %total, + 'description' => 'First payment (depending on day of month)', + 'subtotal' => [ $subtotals{0}, $total ], + }; + + } else { + + push @sections, { + %total, + 'description' => 'First payment', + 'subtotal' => $total, }; } - } - if ( $total_recur > 0 ) { - push @items, { - 'total_item' => $self->mt('Total Recurring'), - 'total_amount' => sprintf('%.2f',$total_recur), - 'break_after' => 1, - }; } - return @items; - + return \@sections, []; } =item enable_previous @@ -342,7 +376,7 @@ sub _items_total { sub enable_previous { 0 } -=item convert_cust_main +=item convert_cust_main [ PARAMS ] If this quotation already belongs to a customer, then returns that customer, as an FS::cust_main object. @@ -354,10 +388,13 @@ packages as real packages for the customer. If there is an error, returns an error message, otherwise, returns the newly-created FS::cust_main object. +Accepts the same params as L. + =cut sub convert_cust_main { my $self = shift; + my $params = shift || {}; my $cust_main = $self->cust_main; return $cust_main if $cust_main; #already converted, don't again @@ -374,7 +411,7 @@ sub convert_cust_main { $self->prospectnum(''); $self->custnum( $cust_main->custnum ); - my $error = $self->replace || $self->order; + my $error = $self->replace || $self->order(undef,$params); if ( $error ) { $dbh->rollback if $oldAutoCommit; return $error; @@ -386,7 +423,7 @@ sub convert_cust_main { } -=item order [ HASHREF ] +=item order [ HASHREF ] [ PARAMS ] This method is for use with quotations which are already associated with a customer. @@ -398,39 +435,88 @@ If HASHREF is passed, it will be filled with a hash mapping the C of each quoted package to the C of the package as ordered. +If PARAMS hashref is passed, the following params are accepted: + +onhold - if true, suspends newly ordered packages + =cut sub order { my $self = shift; my $pkgnum_map = shift || {}; + my $params = shift || {}; + my $details_map = {}; tie my %all_cust_pkg, 'Tie::RefHash'; foreach my $quotation_pkg ($self->quotation_pkg) { my $cust_pkg = FS::cust_pkg->new; $pkgnum_map->{ $quotation_pkg->quotationpkgnum } = $cust_pkg; + # details will be copied below, after package is ordered + $details_map->{ $quotation_pkg->quotationpkgnum } = [ + map { $_->copy_on_order ? $_->detail : () } $quotation_pkg->quotation_pkg_detail + ]; + foreach (qw(pkgpart locationnum start_date contract_end quantity waive_setup)) { $cust_pkg->set( $_, $quotation_pkg->get($_) ); } - # currently only one discount each - my ($pkg_discount) = $quotation_pkg->quotation_pkg_discount; - if ( $pkg_discount ) { - $cust_pkg->set('discountnum', $pkg_discount->discountnum); + # can now have two discounts each (setup and recur) + foreach my $pkg_discount ($quotation_pkg->quotation_pkg_discount) { + my $field = $pkg_discount->setuprecur . '_discountnum'; + $cust_pkg->set($field, $pkg_discount->discountnum); } $all_cust_pkg{$cust_pkg} = []; # no services } + local $SIG{HUP} = 'IGNORE'; + local $SIG{INT} = 'IGNORE'; + local $SIG{QUIT} = 'IGNORE'; + local $SIG{TERM} = 'IGNORE'; + local $SIG{TSTP} = 'IGNORE'; + local $SIG{PIPE} = 'IGNORE'; + + my $oldAutoCommit = $FS::UID::AutoCommit; + local $FS::UID::AutoCommit = 0; + my $dbh = dbh; + my $error = $self->cust_main->order_pkgs( \%all_cust_pkg ); + unless ($error) { + # copy details (copy_on_order filtering handled above) + foreach my $quotationpkgnum (keys %$details_map) { + next unless @{$details_map->{$quotationpkgnum}}; + $error = $pkgnum_map->{$quotationpkgnum}->set_cust_pkg_detail( + 'I', + @{$details_map->{$quotationpkgnum}} + ); + last if $error; + } + } + + if ($$params{'onhold'}) { + foreach my $quotationpkgnum (keys %$pkgnum_map) { + last if $error; + $error = $pkgnum_map->{$quotationpkgnum}->suspend(); + } + } + + if ($error) { + $dbh->rollback if $oldAutoCommit; + return $error; + } + + $dbh->commit or die $dbh->errstr if $oldAutoCommit; + foreach my $quotationpkgnum (keys %$pkgnum_map) { # convert the objects to just pkgnums my $cust_pkg = $pkgnum_map->{$quotationpkgnum}; $pkgnum_map->{$quotationpkgnum} = $cust_pkg->pkgnum; } - $error; + ''; #no error + } =item charge @@ -450,6 +536,7 @@ sub charge { my $cust_pkg_ref = ''; my ( $bill_now, $invoice_terms ) = ( 0, '' ); my $locationnum; + my ( $discountnum, $discountnum_amount, $discountnum_percent ) = ( '','','' ); if ( ref( $_[0] ) ) { $amount = $_[0]->{amount}; $setup_cost = $_[0]->{setup_cost}; @@ -469,6 +556,9 @@ sub charge { $bill_now = exists($_[0]->{bill_now}) ? $_[0]->{bill_now} : ''; $invoice_terms = exists($_[0]->{invoice_terms}) ? $_[0]->{invoice_terms} : ''; $locationnum = $_[0]->{locationnum}; + $discountnum = $_->{setup_discountnum}; + $discountnum_amount = $_->{setup_discountnum_amount}; + $discountnum_percent = $_->{setup_discountnum_percent}; } else { $amount = shift; $setup_cost = ''; @@ -539,12 +629,15 @@ sub charge { # of ordering a customer package, no "bill now") my $quotation_pkg = new FS::quotation_pkg ( { - 'quotationnum' => $self->quotationnum, - 'pkgpart' => $pkgpart, - 'quantity' => $quantity, - #'start_date' => $start_date, - #'no_auto' => $no_auto, - 'locationnum'=> $locationnum, + 'quotationnum' => $self->quotationnum, + 'pkgpart' => $pkgpart, + 'quantity' => $quantity, + #'start_date' => $start_date, + #'no_auto' => $no_auto, + 'locationnum' => $locationnum, + 'setup_discountnum' => $discountnum, + 'setup_discountnum_amount' => $discountnum_amount, + 'setup_discountnum_percent' => $discountnum_percent, } ); $error = $quotation_pkg->insert; @@ -609,6 +702,7 @@ sub estimate { ###### BEGIN TRANSACTION ###### local $@; + local $SIG{__DIE__}; eval { my $temp_dbh = myconnect(); local $FS::UID::dbh = $temp_dbh; @@ -622,7 +716,10 @@ sub estimate { my $cust_main; if ( $cust_or_prospect->isa('FS::prospect_main') ) { $cust_main = $cust_or_prospect->convert_cust_main; - die "$cust_main (simulating customer signup)\n" unless ref $cust_main; + unless ( ref($cust_main) ) { + $temp_dbh->rollback; + die "$cust_main (simulating customer signup)\n"; + } $fake_self->set('prospectnum', ''); $fake_self->set('custnum', $cust_main->custnum); } else { @@ -630,20 +727,28 @@ sub estimate { } # order packages + local($FS::cust_pkg::disable_start_on_hold) = 1; $error = $fake_self->order(\%pkgnum_of); - die "$error (simulating package order)\n" if $error; + if ( $error ) { + $temp_dbh->rollback; + die "$error (simulating package order)\n"; + } my @new_pkgs = map { FS::cust_pkg->by_key($_) } values(%pkgnum_of); # simulate the first bill my %bill_opt = ( + 'estimate' => 1, 'pkg_list' => \@new_pkgs, 'time' => time, # an option to adjust this? 'return_bill' => $return_bill[0], 'no_usage_reset' => 1, ); $error = $cust_main->bill(%bill_opt); - die "$error (simulating initial billing)\n" if $error; + if ( $error ) { + $temp_dbh->rollback; + die "$error (simulating initial billing)\n" if $error; + } # pick dates for future bills my %next_bill_pkgs; @@ -659,7 +764,10 @@ sub estimate { $bill_opt{'return_bill'} = $return_bill[$i] = []; $bill_opt{'pkg_list'} = $next_bill_pkgs{$next_bill}; $error = $cust_main->bill(%bill_opt); - die "$error (simulating recurring billing cycle $i)\n" if $error; + if ( $error ) { + $temp_dbh->rollback; + die "$error (simulating recurring billing cycle $i)\n"; + } $i++; } @@ -674,21 +782,24 @@ sub estimate { warn Dumper(\@return_bill); } - # careful: none of the pkgnums in here are correct outside the sandbox. + # Careful: none of the foreign keys in here are correct outside the sandbox. + # We have a translation table for pkgnums; all others are total lies. + my %quotation_pkg; # quotationpkgnum => quotation_pkg foreach my $qp ($self->quotation_pkg) { $quotation_pkg{$qp->quotationpkgnum} = $qp; $qp->set($_, 0) foreach qw(unitsetup unitrecur); $qp->set('freq', ''); # flush old tax records - foreach ($qp->quotation_pkg_tax, $qp->quotation_pkg_discount) { + foreach ($qp->quotation_pkg_tax) { $error = $_->delete; return "$error (flushing tax records for pkgpart ".$qp->part_pkg->pkgpart.")" if $error; } } - my %quotation_pkg_tax; # quotationpkgnum => taxnum => quotation_pkg_tax obj + my %quotation_pkg_tax; # quotationpkgnum => tax name => quotation_pkg_tax obj + my %quotation_pkg_discount; # quotationpkgnum => setuprecur => quotation_pkg_discount obj for (my $i = 0; $i < scalar(@return_bill); $i++) { my $this_bill = $return_bill[$i]->[0]; @@ -725,8 +836,39 @@ sub estimate { # it may have multiple lineitems with the same pkgnum) $qp->set('unitrecur', $qp->unitrecur + $cust_bill_pkg->unitrecur); } + + # discounts + if ( $cust_bill_pkg->get('discounts') ) { + # discount records are generated as (setup, recur). + # well, not always, sometimes it's just (recur), but fixing this + # is horribly invasive. + my $discount = $cust_bill_pkg->get('discounts')->[0]; + + if ( $discount ) { + # find the quotation_pkg_discount record for this billing pass... + my $setuprecur = $i ? 'recur' : 'setup'; + my $qpd = $quotation_pkg_discount{$quotationpkgnum}{$setuprecur} + ||= qsearchs('quotation_pkg_discount', { + 'quotationpkgnum' => $quotationpkgnum, + 'setuprecur' => $setuprecur, + }); + + if (!$qpd) { #can't happen + warn "$me simulated bill returned a $setuprecur discount but no discount is in effect.\n"; + } + if ($qpd) { + $qpd->set('amount', $discount->amount); + } + } + } # end of discount stuff + } + + # create tax records foreach my $cust_bill_pkg (@nonpkg_lines) { + + my $itemdesc = $cust_bill_pkg->itemdesc; + if ($cust_bill_pkg->feepart) { warn "$me simulated bill included a non-package fee (feepart ". $cust_bill_pkg->feepart.")\n"; @@ -735,20 +877,20 @@ sub estimate { my $links = $cust_bill_pkg->get('cust_bill_pkg_tax_location') || $cust_bill_pkg->get('cust_bill_pkg_tax_rate_location') || []; - # breadth-first unrolled recursion + # breadth-first unrolled recursion: + # take each tax link and any tax-on-tax descendants, and merge them + # into a single quotation_pkg_tax record for each pkgnum/taxname + # combination while (my $tax_link = shift @$links) { my $target = $cust_bill_pkg{ $tax_link->taxable_billpkgnum } - or die "$me unable to resolve tax link (taxnum ".$tax_link->taxnum.")\n"; + or die "$me unable to resolve tax link\n"; if ($target->pkgnum) { my $quotationpkgnum = $quotationpkgnum_of{$target->pkgnum}; # create this if there isn't one yet - my $qpt = - $quotation_pkg_tax{$quotationpkgnum}{$tax_link->taxnum} ||= + my $qpt = $quotation_pkg_tax{$quotationpkgnum}{$itemdesc} ||= FS::quotation_pkg_tax->new({ quotationpkgnum => $quotationpkgnum, - itemdesc => $cust_bill_pkg->itemdesc, - taxnum => $tax_link->taxnum, - taxtype => $tax_link->taxtype, + itemdesc => $itemdesc, setup_amount => 0, recur_amount => 0, }); @@ -763,9 +905,10 @@ sub estimate { } elsif ($target->feepart) { # do nothing; we already warned for the fee itself } else { - # tax on tax: the tax target is another tax item + # tax on tax: the tax target is another tax item. # since this is an estimate, I'm just going to assign it to the - # first of the underlying packages + # first of the underlying packages. (RT#5243 is why we can't have + # nice things.) my $sublinks = $target->cust_bill_pkg_tax_rate_location; if ($sublinks and $sublinks->[0]) { $tax_link->set('taxable_billpkgnum', $sublinks->[0]->taxable_billpkgnum); @@ -775,14 +918,22 @@ sub estimate { } } } # while my $tax_link + } # foreach my $cust_bill_pkg - #XXX discounts } foreach my $quotation_pkg (values %quotation_pkg) { $error = $quotation_pkg->replace; return "$error (recording estimate for ".$quotation_pkg->part_pkg->pkg.")" if $error; } + foreach (values %quotation_pkg_discount) { + # { setup => one, recur => another } + foreach my $quotation_pkg_discount (values %$_) { + $error = $quotation_pkg_discount->replace; + return "$error (recording estimated discount)" + if $error; + } + } foreach my $quotation_pkg_tax (map { values %$_ } values %quotation_pkg_tax) { $error = $quotation_pkg_tax->insert; return "$error (recording estimated tax for ".$quotation_pkg_tax->itemdesc.")" @@ -915,17 +1066,97 @@ sub search_sql_where { =item _items_pkg -Return line item hashes for each package on this quotation. Differs from the -base L version in that it recalculates each quoted package -first, and doesn't implement the "condensed" option. +Return line item hashes for each package on this quotation. =cut sub _items_pkg { my ($self, %options) = @_; - $self->estimate; - # run it through the Template_Mixin engine - return $self->_items_cust_bill_pkg([ $self->quotation_pkg ], %options); + my $escape = $options{'escape_function'}; + my $locale = $self->cust_or_prospect->locale; + + my $preref = $options{'preref_callback'}; + + my $section = $options{'section'}; + my $freq = $section->{'category'}; + my @pkgs = $self->quotation_pkg; + my @items; + die "_items_pkg called without section->{'category'}" + unless defined $freq; + + my %tax_item; # taxname => hashref, will be aggregated AT DISPLAY TIME + # like we should have done in the first place + + foreach my $quotation_pkg (@pkgs) { + my $part_pkg = $quotation_pkg->part_pkg; + my @details = $quotation_pkg->details; + my $setuprecur; + my $this_item = { + 'pkgnum' => $quotation_pkg->quotationpkgnum, + 'description' => $quotation_pkg->desc($locale), + 'ext_description' => \@details, + 'quantity' => $quotation_pkg->quantity, + }; + if ($freq eq '0') { + # setup/one-time + $setuprecur = 'setup'; + if ($part_pkg->freq ne '0') { + # indicate that it's a setup fee on a recur package (cust_bill does + # this too) + $this_item->{'description'} .= ' Setup'; + } + } else { + # recur for this frequency + next if $freq ne $part_pkg->freq; + $setuprecur = 'recur'; + } + + $this_item->{'unit_amount'} = sprintf('%.2f', + $quotation_pkg->get('unit'.$setuprecur)); + $this_item->{'amount'} = sprintf('%.2f', $this_item->{'unit_amount'} + * $quotation_pkg->quantity); + next if $this_item->{'amount'} == 0 and !( + $setuprecur eq 'setup' + ? $quotation_pkg->setup_show_zero + : $quotation_pkg->recur_show_zero + ); + + if ( $preref ) { + $this_item->{'preref_html'} = &$preref($quotation_pkg); + } + + push @items, $this_item; + my $discount = $quotation_pkg->_item_discount(setuprecur => $setuprecur); + if ($discount) { + $_ = &{$escape}($_) foreach @{ $discount->{ext_description} }; + push @items, $discount; + } + + # each quotation_pkg_tax has two amounts: the amount charged on the + # setup invoice, and the amount on the recurring invoice. + foreach my $qpt ($quotation_pkg->quotation_pkg_tax) { + my $this_tax = $tax_item{$qpt->itemdesc} ||= { + 'pkgnum' => 0, + 'description' => $qpt->itemdesc, + 'ext_description' => [], + 'amount' => 0, + }; + $this_tax->{'amount'} += $qpt->get($setuprecur.'_amount'); + } + } # foreach $quotation_pkg + + foreach my $taxname ( sort { $a cmp $b } keys (%tax_item) ) { + my $this_tax = $tax_item{$taxname}; + $this_tax->{'amount'} = sprintf('%.2f', $this_tax->{'amount'}); + next if $this_tax->{'amount'} == 0; + push @items, $this_tax; + } + + return @items; +} + +sub _items_tax { + (); } =back