X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fprepay_credit.pm;h=a0fd7f9a3a34d986826898ac566b8a5837128880;hp=302ba37c75e62f0049b7f7938d31f91db47f0830;hb=f822e27a1e00594332ffa487a1c284234c5580a6;hpb=4883350ca50dba7a76ffc74b59c9d948ecc90c2f

diff --git a/FS/FS/prepay_credit.pm b/FS/FS/prepay_credit.pm
index 302ba37c7..a0fd7f9a3 100644
--- a/FS/FS/prepay_credit.pm
+++ b/FS/FS/prepay_credit.pm
@@ -1,11 +1,12 @@
 package FS::prepay_credit;
+use base qw(FS::Record);
 
 use strict;
-use vars qw( @ISA );
+use vars qw( $DEBUG $me );
 use FS::Record qw(qsearchs dbh);
-use FS::agent;
 
-@ISA = qw(FS::Record);
+$DEBUG = 0;
+$me = '[FS::prepay_credit]';
 
 =head1 NAME
 
@@ -123,20 +124,13 @@ sub check {
 
 Returns the agent (see L<FS::agent>) for this prepaid card, if any.
 
-=cut
-
-sub agent {
-  my $self = shift;
-  qsearchs('agent', { 'agentnum' => $self->agentnum } );
-}
-
 =back
 
 =head1 SUBROUTINES
 
 =over 4
 
-=item generate NUM TYPE HASHREF
+=item generate NUM TYPE LENGTH HASHREF
 
 Generates the specified number of prepaid cards.  Returns an array reference of
 the newly generated card identifiers, or a scalar error message.
@@ -145,11 +139,12 @@ the newly generated card identifiers, or a scalar error message.
 
 #false laziness w/agent::generate_reg_codes
 sub generate {
-  my( $num, $type, $hashref ) = @_;
+  my( $num, $type, $length, $hashref ) = @_;
 
   my @codeset = ();
   push @codeset, ( 'A'..'Z' ) if $type =~ /alpha/;
   push @codeset, ( '1'..'9' ) if $type =~ /numeric/;
+  $length ||= 8;
 
   local $SIG{HUP} = 'IGNORE';
   local $SIG{INT} = 'IGNORE';
@@ -163,13 +158,22 @@ sub generate {
   my $dbh = dbh;
 
   my $condup = 0; #don't retry forever
-
+  
   my @cards = ();
   for ( 1 ... $num ) {
 
-    my $identifier = join('', map($codeset[int(rand $#codeset)], (0..7) ) );
-
-    redo if qsearchs('prepay_credit',{identifier=>$identifier}) && $condup++<23;
+    my $identifier = join('', map($codeset[int(rand $#codeset)], (1..$length) ) );
+
+    if ( qsearchs('prepay_credit',{identifier=>$identifier}) ) {
+      if ( $condup++ < 54 ) {
+        warn "$me generate: duplicate identifier $identifier; retrying\n"
+          if $DEBUG;
+        redo;
+      } else {
+        warn "$me generate: giving up after 54 tries"
+          if $DEBUG;
+      }
+    }
     $condup = 0;
 
     my $prepay_credit = new FS::prepay_credit {