X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fflat_introrate.pm;h=4c9abebc9d2936f73fb6d983155af61a30fdda8f;hp=33cc3d48a52456be28a39457b745c9d6cc298013;hb=4d32fe65cf99b766886fdfad4d8d3c7a3537bbc1;hpb=6231b4d0a5f2c78cca6ba10adb920b4ada986f14 diff --git a/FS/FS/part_pkg/flat_introrate.pm b/FS/FS/part_pkg/flat_introrate.pm index 33cc3d48a..4c9abebc9 100644 --- a/FS/FS/part_pkg/flat_introrate.pm +++ b/FS/FS/part_pkg/flat_introrate.pm @@ -1,12 +1,35 @@ package FS::part_pkg::flat_introrate; +use base qw( FS::part_pkg::flat ); use strict; -use vars qw(@ISA %info $DEBUG $me); -use FS::part_pkg::flat; +use vars qw( %info ); -@ISA = qw(FS::part_pkg::flat); -$me = '[' . __PACKAGE__ . ']'; -$DEBUG = 0; +use FS::Log; + +# mostly false laziness with FS::part_pkg::global_Mixin::validate_moneyn, +# except for blank string handling... +sub validate_money { + my ($option, $valref) = @_; + if ( $$valref eq '' ) { + $$valref = '0'; + } elsif ( $$valref =~ /^\s*(\d*)(\.\d{1})\s*$/ ) { + #handle one decimal place without barfing out + $$valref = ( ($1||''). ($2.'0') ) || 0; + } elsif ( $$valref =~ /^\s*(\d*)(\.\d{2})?\s*$/ ) { + $$valref = ( ($1||''). ($2||'') ) || 0; + } else { + return "Illegal (money) $option: ". $$valref; + } + return ''; +} + +sub validate_number { + my ($option, $valref) = @_; + $$valref = 0 unless $$valref; + return "Invalid $option" + unless ($$valref) = ($$valref =~ /^\s*(\d+)\s*$/); + return ''; +} %info = ( 'name' => 'Introductory price for X months, then flat rate,'. @@ -16,29 +39,52 @@ $DEBUG = 0; 'fields' => { 'intro_fee' => { 'name' => 'Introductory recurring fee for this package', 'default' => 0, + 'validate' => \&validate_money, }, 'intro_duration' => { 'name' => 'Duration of the introductory period, in number of months', 'default' => 0, + 'validate' => \&validate_number, + }, + 'show_as_discount' => + { 'name' => 'Show the introductory rate on the invoice as if it\'s a discount', + 'type' => 'checkbox', }, }, - 'fieldorder' => [ qw(intro_duration intro_fee) ], + 'fieldorder' => [ qw(intro_duration intro_fee show_as_discount) ], 'weight' => 14, ); -sub base_recur { - my($self, $cust_pkg, $time ) = @_; +sub intro_end { + my($self, $cust_pkg) = @_; + my ($duration) = ($self->option('intro_duration') =~ /^\s*(\d+)\s*$/); + unless (length($duration)) { + my $log = FS::Log->new('FS::part_pkg'); + $log->warning("Invalid intro_duration '".$self->option('intro_duration')."' on pkgpart ".$self->pkgpart + .", defaulting to 0, check package definition"); + $duration = 0; + } - warn "flat_introrate base_recur requires date!" if !$time; - my $now = $time ? $$time : time; + # no setup or start_date means "start billing the package ASAP", so assume + # it would start billing right now. + my $start = $cust_pkg->setup || $cust_pkg->start_date || time; - my ($duration) = ($self->option('intro_duration') =~ /^(\d+)$/); - unless ($duration) { - die "Invalid intro_duration: " . $self->option('intro_duration'); + $self->add_freq($start, $duration); +} + +sub base_recur { + my($self, $cust_pkg, $sdate ) = @_; + + my $now; + if (!$sdate) { # the "$sdate" from _make_lines + my $log = FS::Log->new('FS::part_pkg'); + $log->warning("flat_introrate base_recur requires date!"); + $now = time; + } else { + $now = $$sdate; } - my $intro_end = $self->add_freq($cust_pkg->setup, $duration); - if ($now < $intro_end) { + if ($now < $self->intro_end($cust_pkg)) { return $self->option('intro_fee'); } else { return $self->option('recur_fee'); @@ -46,5 +92,26 @@ sub base_recur { } +sub item_discount { + my ($self, $cust_pkg) = @_; + return unless $self->option('show_as_discount',1); + my $intro_end = $self->intro_end($cust_pkg); + my $amount = sprintf('%.2f', + $self->option('intro_fee') - $self->option('recur_fee') + ); + return unless $amount < 0; + # otherwise it's an "introductory surcharge"? not the intended use of + # the feature. + + { '_is_discount' => 1, + 'description' => $cust_pkg->mt('Introductory discount until') . ' ' . + $cust_pkg->time2str_local('short', $intro_end), + 'setup_amount' => 0, + 'recur_amount' => $amount, + 'ext_description' => [], + 'pkgpart' => $self->pkgpart, + 'feepart' => '', + } +} 1;