X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fflat_introrate.pm;h=1fc9cd262e7a81d89f1b5813b809d6a559ed7f1c;hp=1447730e73d9d9c21897539a7ec2df1c3b652af9;hb=5fd15230317a0a6b6fcb70d5b83712c8f827ebb1;hpb=d3ce5efd1ec0e1a715a154696e2b0aa86e51c27b diff --git a/FS/FS/part_pkg/flat_introrate.pm b/FS/FS/part_pkg/flat_introrate.pm index 1447730e7..1fc9cd262 100644 --- a/FS/FS/part_pkg/flat_introrate.pm +++ b/FS/FS/part_pkg/flat_introrate.pm @@ -1,14 +1,10 @@ package FS::part_pkg::flat_introrate; +use base qw( FS::part_pkg::flat ); use strict; -use vars qw(@ISA %info $DEBUG $me); -use FS::part_pkg::flat; +use vars qw( %info ); -use Date::Manip qw(DateCalc UnixDate ParseDate); - -@ISA = qw(FS::part_pkg::flat); -$me = '[' . __PACKAGE__ . ']'; -$DEBUG = 0; +use FS::Log; %info = ( 'name' => 'Introductory price for X months, then flat rate,'. @@ -31,29 +27,24 @@ $DEBUG = 0; sub base_recur { my($self, $cust_pkg, $time ) = @_; + warn "flat_introrate base_recur requires date!" if !$time; my $now = $time ? $$time : time; - my ($duration) = ($self->option('intro_duration') =~ /^(\d+)$/); - unless ($duration) { - die "Invalid intro_duration: " . $self->option('intro_duration'); + my ($duration) = ($self->option('intro_duration') =~ /^\s*(\d+)\s*$/); + unless (length($duration)) { + my $log = FS::Log->new('FS::part_pkg'); + $log->warning("Invalid intro_duration '".$self->option('intro_duration')."' on pkgpart ".$self->pkgpart + .", defaulting to 0, check package definition"); + $duration = 0; } + my $intro_end = $self->add_freq($cust_pkg->setup, $duration); - my $setup = &ParseDate('epoch ' . $cust_pkg->getfield('setup')); - my $intro_end = &DateCalc($setup, "+${duration} month"); - my $recur; - - warn "$me: \$duration = ${duration}" if $DEBUG; - warn "$me: \$intro_end = ${intro_end}" if $DEBUG; - warn "$me: $now < " . &UnixDate($intro_end, '%s') if $DEBUG; - - if ($now < &UnixDate($intro_end, '%s')) { - $recur = $self->option('intro_fee'); + if ($now < $intro_end) { + return $self->option('intro_fee'); } else { - $recur = $self->option('recur_fee'); + return $self->option('recur_fee'); } - $recur; - }