X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=blobdiff_plain;f=FS%2FFS%2Fcust_bill_pkg_void.pm;h=883869b21a99c80508dac6fedc09d0f87d1ffe56;hp=4b9cffd4e172dcafe3fd9bca81f9a3852b6ed9e5;hb=dc83512c36dc6bea2585abada4f88d714c600e55;hpb=6d34c5060a4e5e9338ebc0d04459861a5c45e812 diff --git a/FS/FS/cust_bill_pkg_void.pm b/FS/FS/cust_bill_pkg_void.pm index 4b9cffd4e..883869b21 100644 --- a/FS/FS/cust_bill_pkg_void.pm +++ b/FS/FS/cust_bill_pkg_void.pm @@ -2,6 +2,7 @@ package FS::cust_bill_pkg_void; use base qw( FS::TemplateItem_Mixin FS::reason_Mixin FS::Record ); use strict; +use vars qw( $me $DEBUG ); use FS::Record qw( qsearch qsearchs dbh fields ); use FS::cust_bill_void; use FS::cust_bill_pkg_detail; @@ -12,6 +13,10 @@ use FS::cust_bill_pkg_fee; use FS::cust_bill_pkg_tax_location; use FS::cust_bill_pkg_tax_rate_location; use FS::cust_tax_exempt_pkg; +use FS::Cursor; + +$me = '[ FS::cust_bill_pkg_void ]'; +$DEBUG = 0; =head1 NAME @@ -110,7 +115,7 @@ freeform string (deprecated) =item reasonnum -reason for voiding the payment (see L) +reason for voiding the payment (see L) =back @@ -279,6 +284,48 @@ sub cust_bill_pkg_fee { qsearch( 'cust_bill_pkg_fee_void', { 'billpkgnum' => $self->billpkgnum } ); } +# _upgrade_data +# +# Used by FS::Upgrade to migrate to a new database. +sub _upgrade_data { # class method + my ($class, %opts) = @_; + + warn "$me upgrading $class\n" if $DEBUG; + + $class->_upgrade_reasonnum(%opts); + my $error; + # fix voids with tax from before July 2013, when the taxable_billpkgnum + # field was added to the void table + local $FS::Record::nowarn_classload = 1; + my $search = FS::Cursor->new({ + 'table' => 'cust_bill_pkg_tax_location_void', + 'hashref' => { 'taxable_billpkgnum' => '' } + }); + while (my $void = $search->fetch) { + # the history for the unvoided record should have the correct + # taxable_billpkgnum + my $num = $void->billpkgtaxlocationnum; + my $unvoid = qsearchs({ + 'table' => 'h_cust_bill_pkg_tax_location', + 'hashref' => { 'billpkgtaxlocationnum' => $num }, + 'extra_sql' => ' AND taxable_billpkgnum IS NOT NULL', + 'order_by' => ' ORDER BY history_date DESC LIMIT 1' + }); + if (!$unvoid) { + # should never happen + # but should this be fatal? or wait until someone actually tries to + # use the record? + warn "billpkgtaxlocationnum $num: could not find pre-void history record to restore taxable_billpkgnum."; + } + if ($unvoid) { + $void->set('taxable_billpkgnum', $unvoid->taxable_billpkgnum); + $error = $void->replace; + die "billpkgtaxlocationnum $num: $error\n" if $error; + } + } + +} + =back =head1 BUGS