mkdir patch from Ofer

diff --git a/Changes b/Changes
index 53c78f1..956d538 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 Revision history for Perl extension Net::SCP.
 
+0.08  unreleased
+       - Fix mkdir error message and extraneous warning, patch from Ofer Nave
+         <onave@bizrate.com>, thanks!
+
 0.07  Wed Mar  3 00:38:25 2004
        - get and put methods use OO-style scp to avoid clobbering errstr,
          thanks to paguerlais@airfrance.fr

diff --git a/SCP.pm b/SCP.pm
index 6347cae..2b19b7e 100644 (file)
--- a/SCP.pm
+++ b/SCP.pm
@@ -12,7 +12,7 @@ use IPC::Open3;
 
 @ISA = qw(Exporter);
 @EXPORT_OK = qw( scp iscp );
-$VERSION = '0.07';
+$VERSION = '0.08';
 
 $scp = "scp";
 
@@ -231,8 +231,8 @@ sub mkdir {
                       '/bin/mkdir', '-p ', shell_quote($directory) );
   waitpid $pid, 0;
   if ( $? >> 8 ) {
-    chomp(my $errstr = <$error>);
-    $self->{errstr} = $errstr || "mkdir exited with status ". $?>>8;
+    chomp(my $errstr = <$error> || '');
+    $self->{errstr} = $errstr || "mkdir exited with status ". ($?>>8);
     return 0;
   }
   1;