X-Git-Url: http://git.freeside.biz/gitweb/?p=Net-SCP.git;a=blobdiff_plain;f=SCP.pm;h=2eca5dee532a105a3dfaa19ad6f0438cc5abd2f8;hp=0e41e3ddbade83172208fa09b18d1f640ca53c36;hb=HEAD;hpb=39a05dcd4f7edf5eb89c2870eff5ae2df8bb381b diff --git a/SCP.pm b/SCP.pm index 0e41e3d..2eca5de 100644 --- a/SCP.pm +++ b/SCP.pm @@ -1,7 +1,7 @@ package Net::SCP; use strict; -use vars qw($VERSION @ISA @EXPORT_OK $scp); +use vars qw($VERSION @ISA @EXPORT_OK $scp $DEBUG); use Exporter; use Carp; use File::Basename; @@ -12,10 +12,12 @@ use IPC::Open3; @ISA = qw(Exporter); @EXPORT_OK = qw( scp iscp ); -$VERSION = '0.06'; +$VERSION = '0.09'; $scp = "scp"; +$DEBUG = 0; + =head1 NAME Net::SCP - Perl extension for secure copy protocol @@ -44,7 +46,6 @@ Net::SCP - Perl extension for secure copy protocol $scp->cwd("/dir"); $scp->size("file"); $scp->get("file"); - $scp->quit; =head1 DESCRIPTION @@ -74,7 +75,7 @@ sub scp { $flags .= 'r' unless &_islocal($src) && ! -d $src; my @cmd; if ( ( defined($interact) && $interact ) - || ( defined($self->{interact}) && $self->{interact} ) ) { + || ( defined($self->{interactive}) && $self->{interactive} ) ) { @cmd = ( $scp, $flags, $src, $dest ); print join(' ', @cmd), "\n"; unless ( &_yesno ) { @@ -88,6 +89,7 @@ sub scp { my($reader, $writer, $error ) = ( new IO::Handle, new IO::Handle, new IO::Handle ); $writer->autoflush(1);# $error->autoflush(1); + local $SIG{CHLD} = 'DEFAULT'; my $pid = open3($writer, $reader, $error, @cmd ); waitpid $pid, 0; if ( $? >> 8 ) { @@ -115,7 +117,7 @@ Returns false and sets the B attribute if there is an error. sub iscp { if ( ref($_[0]) ) { my $self = shift; - $self->{'interact'} = 1; + $self->{'interactive'} = 1; $self->scp(@_); } else { scp(@_, 1); @@ -203,7 +205,7 @@ sub get { $local ||= basename($remote); my $source = $self->{'host'}. ":$remote"; $source = $self->{'user'}. '@'. $source if $self->{'user'}; - scp($source,$local); + $self->scp($source,$local); } =item mkdir DIRECTORY @@ -229,8 +231,8 @@ sub mkdir { '/bin/mkdir', '-p ', shell_quote($directory) ); waitpid $pid, 0; if ( $? >> 8 ) { - chomp(my $errstr = <$error>); - $self->{errstr} = $errstr || "mkdir exited with status ". $?>>8; + chomp(my $errstr = <$error> || ''); + $self->{errstr} = $errstr || "mkdir exited with status ". ($?>>8); return 0; } 1; @@ -288,8 +290,8 @@ sub put { $remote = $self->{'cwd'}. "/$remote" if $self->{'cwd'} && $remote !~ /^\//; my $dest = $self->{'host'}. ":$remote"; $dest = $self->{'user'}. '@'. $dest if $self->{'user'}; - warn "scp $local $dest\n"; - scp($local, $dest); + warn "scp $local $dest\n" if $DEBUG; + $self->scp($local, $dest); } =item binary @@ -300,6 +302,14 @@ Compatibility method: does nothing; returns true. sub binary { 1; } +=item quit + +Compatibility method: does nothing; returns true. + +=cut + +sub quit { 1; } + =back =head1 FREQUENTLY ASKED QUESTIONS @@ -307,28 +317,84 @@ sub binary { 1; } Q: How do you supply a password to connect with ssh within a perl script using the Net::SSH module? -A: You don't. Use RSA or DSA keys. See the ssh-keygen(1) manpage. +A: You don't (at least not with this module). Use RSA or DSA keys. See the + quick help in the next section and the ssh-keygen(1) manpage. -Q: My script is "leaking" ssh processes. +A #2: See L instead. + +Q: My script is "leaking" scp processes. A: See L, L, L and L. +=head1 GENERATING AND USING SSH KEYS + +=over 4 + +=item 1 Generate keys + +Type: + + ssh-keygen -t rsa + +And do not enter a passphrase unless you wanted to be prompted for +one during file copying. + +Here is what you will see: + + $ ssh-keygen -t rsa + Generating public/private rsa key pair. + Enter file in which to save the key (/home/User/.ssh/id_rsa): + Enter passphrase (empty for no passphrase): + + Enter same passphrase again: + + Your identification has been saved in /home/User/.ssh/id_rsa. + Your public key has been saved in /home/User/.ssh/id_rsa.pub. + The key fingerprint is: + 5a:cd:2b:0a:cd:d9:15:85:26:79:40:0c:55:2a:f4:23 User@JEFF-CPU + + +=item 2 Copy public to machines you want to upload to + +C is your public key. Copy it to C<~/.ssh> on target machine. + +Put a copy of the public key file on each machine you want to log into. +Name the copy C (some implementations name this file +C) + +Then type: + + chmod 600 authorized_keys + +Then make sure your home dir on the remote machine is not group or +world writeable. + +=back + =head1 AUTHORS Ivan Kohler +Assistance wanted - this module could really use a maintainer with enough time +to at least review and apply more patches. Or the module should just be +deprecated in favor of Net::SFTP::Expect or Net::SFTP::Foreign and made into a +simple compatiblity wrapper. Please email Ivan if you are interested in +helping. + Major updates Anthony Deaver Thanks to Jon Gunnip for fixing a bug with size(). -Patch for the mkdir method by Anthony Awtrey +Patch for the mkdir method by Anthony Awtrey . + +Thanks to terrence brannon for the documentation in +the GENERATING AND USING SSH KEYS section. =head1 COPYRIGHT -Copyright (c) 2000 Ivan Kohler. -Copyright (c) 2000 Silicon Interactive Software Design. -Copyright (c) 2000 Freeside Internet Services, LLC +Copyright (c) 2000 Ivan Kohler +Copyright (c) 2007 Freeside Internet Services, Inc. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. @@ -339,14 +405,32 @@ Still has no-OO cruft. In order to work around some problems with commercial SSH2, if the source file is on the local system, and is not a directory, the B<-r> flag is omitted. - -It's probably better just to use SSH1 or OpenSSH +It's probably better just to use OpenSSH which is +the de-facto standard these days anyway. The Net::FTP-style OO stuff is kinda lame. And incomplete. +iscp doesnt expect you to be logging into the box that you are copying to +for the first time. so it's completely clueless about how to handle the +whole 'add this file to known hosts' message so it just hangs after the +user hits y. (Thanks to John L. Utz III). To avoid this, SSH to the box +once first. + =head1 SEE ALSO -scp(1), ssh(1) +For a perl implementation that does not require the system B command, see +L instead. + +For a wrapper version that allows you to use passwords, see L +instead. + +For a wrapper version of the newer SFTP protocol, see L +instead. + +L, L, L, L, +L + +scp(1), ssh(1), L, L, L =cut