From 5426737664dd0fd517c2f4f931fa04852e95d1ca Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Mon, 12 May 2014 16:16:43 -0700 Subject: [PATCH] Depend on Net::SSLeay and test on it (and not Crypt::SSLeay), to eliminate spurious test failures and increase installability. Alas, but the last four years have not provided OR relationships in CPAN dependencies. --- Changes | 6 ++++++ Makefile.PL | 5 +++++ lib/Net/HTTPS/Any.pm | 2 +- t/get-cryptssleay.t | 3 +++ t/post-cryptssleay.t | 3 +++ 5 files changed, 18 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index 61dcc92..477a59c 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,12 @@ Revision history for Net-HTTPS-Any 0.11 unreleased - doc: update example in synopsis + - Depend on Net::SSLeay and test on it (and not Crypt::SSLeay), to + eliminate spurious test failures and increase installability. Alas, + but the last four years have not provided OR relationships in CPAN + dependencies. + - TODO: document our usage of LWP isn't necessarily Crypt::SSLeay with + new (which?) LWP versions. 0.10 Sat May 1 13:39:39 PDT 2010 - Pull in changes from Business::OnlinePayment::HTTPS 0.09 from diff --git a/Makefile.PL b/Makefile.PL index 2fe34d0..3181e4a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -17,6 +17,11 @@ WriteMakefile( # 'Net::SSLeay' => 0, # or 'Crypt::SSLeay' => 0, # 'LWP' => 0, + + #failing tests is worse, Net::SSLeay appears to finally have emerged + # as best-practice with the release of LWP::Protocol::https that uses + # IO::Socket::SSL and therefore Net::SSLeay + 'Net::SSLeay' => 0, }, dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, clean => { FILES => 'Net-HTTPS-Any-*' }, diff --git a/lib/Net/HTTPS/Any.pm b/lib/Net/HTTPS/Any.pm index 17faa74..0631d73 100644 --- a/lib/Net/HTTPS/Any.pm +++ b/lib/Net/HTTPS/Any.pm @@ -47,7 +47,7 @@ Net::HTTPS::Any - Simple HTTPS client using whichever underlying SSL module is a =cut -our $VERSION = '0.11'; +our $VERSION = '0.11_01'; =head1 SYNOPSIS diff --git a/t/get-cryptssleay.t b/t/get-cryptssleay.t index 53f1cdb..fa2ef21 100644 --- a/t/get-cryptssleay.t +++ b/t/get-cryptssleay.t @@ -5,6 +5,9 @@ use warnings; use Test::More; BEGIN { + + plan skip_all => "LWP tests disabled to avoid excessive dependencies"; + plan( tests=>4 ); $Net::HTTPS::Any::skip_NetSSLeay=1; $Net::HTTPS::Any::skip_NetSSLeay=1; diff --git a/t/post-cryptssleay.t b/t/post-cryptssleay.t index 168f1ea..7f99b0a 100644 --- a/t/post-cryptssleay.t +++ b/t/post-cryptssleay.t @@ -5,6 +5,9 @@ use warnings; use Test::More; BEGIN { + + plan skip_all => "LWP tests disabled to avoid excessive dependencies"; + plan( tests=>4 ); $Net::HTTPS::Any::skip_NetSSLeay=1; $Net::HTTPS::Any::skip_NetSSLeay=1; -- 2.11.0