From f0b9b398d11b68812ec480c05f8d484305ec9131 Mon Sep 17 00:00:00 2001 From: plobbes Date: Mon, 20 Nov 2006 06:27:14 +0000 Subject: [PATCH] - minor cleanup of test drivers - fix "submit unchanged" test case: now wrapped with _pre_submit() always --- t/bop.t | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/t/bop.t b/t/bop.t index 59b1772..2aaf223 100644 --- a/t/bop.t +++ b/t/bop.t @@ -1,5 +1,5 @@ #!/usr/bin/perl -# $Id: bop.t,v 1.8 2006-11-20 05:29:14 plobbes Exp $ +# $Id: bop.t,v 1.9 2006-11-20 06:27:14 plobbes Exp $ use strict; use warnings; @@ -18,19 +18,15 @@ BEGIN { use_ok("Business::OnlinePayment") or exit; } { # fake test driver 2 (with submit method that dies) package Business::OnlinePayment::MOCK2; - use strict; - use warnings; - use base qw(Business::OnlinePayment); - sub submit { die("in processor submit\n"); } + use base qw(Business::OnlinePayment::MOCK1); + sub submit { my $self = shift; die("in processor submit\n"); } } { # fake test driver 3 (with submit method) package Business::OnlinePayment::MOCK3; - use strict; - use warnings; - use base qw(Business::OnlinePayment); - sub submit { return (1); } + use base qw(Business::OnlinePayment::MOCK1); + sub submit { my $self = shift; return 1; } } my $package = "Business::OnlinePayment"; @@ -197,7 +193,7 @@ foreach my $drv (@drivers) { eval { $obj->submit; }; like( $@, qr/^Processor subclass did not /, "missing submit() croaks" ); - is( $obj->can("submit"), $package->can("submit"), "submit unchanged" ); + isnt( $obj->can("submit"), $package->can("submit"), "submit changed" ); my $mock2 = $package->new("MOCK2"); can_ok( $mock2, qw(submit) ); -- 2.11.0