we don't use B:OP:HTTPS yet, no need to depent on B:OP v3. correct Makefile.PL wrt...

[Business-OnlinePayment-Skipjack.git] / Skipjack.pm

diff --git a/Skipjack.pm b/Skipjack.pm
index e20eaf1..dc2e0a4 100644 (file)
--- a/Skipjack.pm
+++ b/Skipjack.pm
@@ -22,15 +22,16 @@ package Business::OnlinePayment::Skipjack;
 
 use strict;
 use Carp;
-use Business::OnlinePayment 3;
-use Business::OnlinePayment::HTTPS;
+use Business::OnlinePayment ;#3;
+#use Business::OnlinePayment::HTTPS;
 use Text::CSV_XS;
 use vars qw( @ISA $VERSION $DEBUG );
 
-$VERSION = "0.2";
+$VERSION = "0.3";
 $DEBUG = 0;
 
-@ISA = qw( Business::OnlinePayment::HTTPS );
+#@ISA = qw( Business::OnlinePayment::HTTPS );
+@ISA = qw( Business::OnlinePayment );
 
 my %CC_ERRORS = (
         '-1'    =>      'Invalid length (-1)',
@@ -429,12 +430,14 @@ sub parse_SJAPI_TransactionChangeStatusRequest
 
   my @records = split(/\r\n/, $page);
 
-  $csv->parse(shift @records) or die $csv->error;
+  $csv->parse(shift @records)
+    or die "CSV parse failed on " . $csv->error_input;
   @output{@CHANGE_STATUS_RESPONSE} = $csv->fields();
 
   # we only handle a single record reponse, as that's all this module will
   #  currently submit...
-  $csv->parse(shift @records) or die $csv->error;
+  $csv->parse(shift @records)
+    or die "CSV parse failed on " . $csv->error_input;
   @output{@CHANGE_STATUS_RESPONSE_RECORD} = $csv->fields();
 
   return %output;
@@ -451,12 +454,15 @@ sub parse_SJAPI_TransactionStatusRequest
 
   my @records = split(/\r\n/, $page);
 
-  $csv->parse(shift @records) or die $csv->error;
+  #$csv->parse(shift @records)
+  $csv->parse(shift @records)
+    or die "CSV parse failed on " . $csv->error_input;
   @output{@GET_STATUS_RESPONSE} = $csv->fields();
 
   # we only handle a single record reponse, as that's all this module will
   #  currently submit...
-  $csv->parse(shift @records) or die $csv->error;
+  $csv->parse(shift @records)
+    or die "CSV parse failed on " . $csv->error_input;
   @output{@GET_STATUS_RESPONSE_RECORD} = $csv->fields();
 
   return %output;
@@ -572,11 +578,13 @@ Skipjack's TransactionStatusRequest.  It should be documented.
 
 =head1 AUTHOR
 
-Original Skipjack.pm developed by New York Connect Net (http://nyct.net)
-Michael Bacarella <mbac@nyct.net>
+Inspiried by (but no longer contains) code from:
 
-Modified for GetCareer.com by Slipstream.com
-Troy Davis <troy@slipstream.com>
+  Original Skipjack.pm developed by New York Connect Net (http://nyct.net)
+  Michael Bacarella <mbac@nyct.net>
+
+  Modified for GetCareer.com by Slipstream.com
+  Troy Davis <troy@slipstream.com>
 
 'Adapted' (completely rewritten) for Business::OnlinePayment 
 by Fire2Wire Internet Services (http://www.fire2wire.com)
@@ -588,14 +596,18 @@ Boring 0.2 update by Ivan Kohler <ivan-skipjack@420.am>
 
 =head1 COPYRIGHT
 
-original license unknown, pending contact from Michael Bacarella / nyct.net.
-assuming it is okay...
-
-Business::OnlinePayment rewrite:
 Copyright (c) 2006 Fire2Wire Internet Services (http://www.fire2wire.com)
 All rights reserved.  This program is free software; you can redistribute it
 and/or modify it under the same terms as Perl itself.
 
+Inspiried by (but no longer contains) code from:
+
+  Original Skipjack.pm developed by New York Connect Net (http://nyct.net)
+  Michael Bacarella <mbac@nyct.net>
+
+  Modified for GetCareer.com by Slipstream.com
+  Troy Davis <troy@slipstream.com>
+
 =head1 SEE ALSO
 
 L<Business::OnlinePayment>