From: plobbes <plobbes>
Date: Tue, 22 Sep 2009 21:15:44 +0000 (+0000)
Subject: - version 1.01: rt.cpan.org#49349: Fix Reference Transactions
X-Git-Url: http://git.freeside.biz/gitweb/?p=Business-OnlinePayment-PayflowPro.git;a=commitdiff_plain

- version 1.01: rt.cpan.org#49349: Fix Reference Transactions
---

diff --git a/Changes b/Changes
index 9011bb3..c4dad1a 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Business::OnlinePayment::PayflowPro.
 
+1.01  Tue Sep 22 17:03:00 EDT 2009 plobbes
+	- rt.cpan.org#49349: Fix Reference Transactions
+	  NOTE: enable in PayfloPro manager transaction settings
+	  Josh Rosenbaum
+
 1.00  Sat Aug 22 01:13:34 EDT 2009 plobbes
 	- bump version to 1.00, should have probably done this with
 	  0.07 as it was a radical enough departure from 0.06, also
diff --git a/PayflowPro.pm b/PayflowPro.pm
index 6f49649..d95affc 100644
--- a/PayflowPro.pm
+++ b/PayflowPro.pm
@@ -8,7 +8,7 @@ use Business::OnlinePayment::HTTPS 0.06;
 
 use base qw(Business::OnlinePayment::HTTPS);
 
-$VERSION = '1.00';
+$VERSION = '1.01';
 $VERSION = eval $VERSION;
 $DEBUG   = 0;
 
@@ -222,19 +222,17 @@ sub submit {
     %content = $self->content;
 
     my @required = qw( TRXTYPE TENDER PARTNER VENDOR USER PWD );
+
+    # NOTE: we croak above if transaction_type ne 'C'
     if ( $self->transaction_type() eq 'C' ) {    # credit card
-        if (   $content{'action'} =~ /^[CDV]$/
-            && defined( $content{'ORIGID'} )
-            && length( $content{'ORIGID'} ) )
-        {
+        if ( defined( $content{'ORIGID'} ) && length( $content{'ORIGID'} ) ) {
             push @required, qw(ORIGID);
         }
         else {
-
-            # never get here, we croak above if transaction_type ne 'C'
             push @required, qw(AMT ACCT EXPDATE);
         }
     }
+
     $self->required_fields(@required);
 
     my %params = $self->get_fields(