- incorporate most of patches from Frédéric Brière, including tests

  for cvv2_code client_certification_id client_timeout request_id

diff --git a/t/bop.t b/t/bop.t
index c41188d..2fbab5a 100644 (file)
--- a/t/bop.t
+++ b/t/bop.t
@@ -2,7 +2,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 11;
+use Test::More tests => 24;
 
 use Business::OnlinePayment;
 
@@ -30,6 +30,39 @@ my $driver  = "PayflowPro";
     is( $obj->port, "443", "port(443)" );
 }
 
+{    # cvv2_response / cvv2_code
+    my $obj = $package->new($driver);
+
+    my $exp = "Z";
+    $obj->cvv2_response($exp);
+
+    is( $obj->cvv2_response, $exp, "cvv2_response() is set" );
+    is( $obj->cvv2_code,     $exp, "cvv2_code() calls cvv2_response" );
+}
+
+{    # client_certification_id
+    my $obj = $package->new($driver);
+
+    my $id = $obj->client_certification_id;
+    isnt( $id, "", "client_certification_id() is set" );
+
+    $id = "foo";
+    is( $obj->client_certification_id($id),
+        $id, "client_certification_id() can be set" );
+    is( $obj->client_certification_id,
+        $id, "client_certification_id() remains set" );
+}
+
+{    # client_timeout
+    my $obj = $package->new($driver);
+
+    is( $obj->client_timeout, 45, "client_timeout() returns 45 by default" );
+
+    my $to = 60;
+    is( $obj->client_timeout($to), $to, "client_timeout() can be set" );
+    is( $obj->client_timeout, $to, "client_timeout() remains set" );
+}
+
 {    # expdate
     my $obj = $package->new($driver);
     my @exp = (
@@ -49,3 +82,19 @@ my $driver  = "PayflowPro";
         is( $mmyy, $moyr, "$exp: MMYY '$mmyy' eq '$moyr' from $exp" );
     }
 }
+
+{    # request_id
+    my $obj = $package->new($driver);
+
+    my $id = $obj->request_id;
+    isnt( $id, "", "request_id() returns something" );
+
+    is( $obj->request_id, $id, "request_id() returns the same value" );
+
+    $obj = $package->new($driver);
+    isnt( $obj->request_id, $id, "request_id() is different for each object" );
+
+    $id = "foo";
+    is( $obj->request_id($id), $id, "request_id() can be set" );
+    is( $obj->request_id, $id, "request_id() remains set" );
+}