From 2fcb22b534898f165cddcbbf8822020e77c8f248 Mon Sep 17 00:00:00 2001
From: fbriere <fbriere>
Date: Fri, 17 Feb 2006 23:50:49 +0000
Subject: [PATCH] Moved success codes to constant

---
 InternetSecure.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/InternetSecure.pm b/InternetSecure.pm
index f2811ab..10d7d6e 100755
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -15,6 +15,8 @@ use base qw(Business::OnlinePayment Exporter);
 our $VERSION = '0.01';
 
 
+use constant SUCCESS_CODES => qw(2000 90000 900P1);
+
 use constant CARD_TYPES => {
 				VI => 'Visa',
 				MC => 'MasterCard',
@@ -237,9 +239,6 @@ sub parse_response {
  			SuppressEmpty => undef,
 		);
 	
-	my $code = $self->result_code($response->{Page});
-	$self->is_success($code eq '2000' || $code eq '90000' || $code eq '900P1');
-
 	$self->infuse($response,
 			result_code	=> 'Page',
 			error_message	=> 'Verbiage',
@@ -258,6 +257,8 @@ sub parse_response {
 			total_amount	=> 'TotalAmount',
 			);
 	
+	$self->is_success(scalar grep $self->result_code eq $_, SUCCESS_CODES);
+
 	# Completely undocumented field that sometimes override <Verbiage>
 	$self->error_message($response->{Error}) if $response->{Error};
 
-- 
2.11.0