Simplify tax/currency initialization
authorfbriere <fbriere>
Thu, 16 Feb 2006 23:46:45 +0000 (23:46 +0000)
committerfbriere <fbriere>
Thu, 16 Feb 2006 23:46:45 +0000 (23:46 +0000)
InternetSecure.pm

index 65a9112..bb052b9 100755 (executable)
@@ -148,13 +148,11 @@ sub to_xml {
        croak 'Unsupported action'
                unless $content{action} =~ /^Normal Authori[zs]ation$/i;
        
-       $content{currency} ||= 'CAD';
-       $content{currency} = uc $content{currency};
+       $content{currency} = uc($content{currency} || 'CAD');
        croak "Unknown currency code ", $content{currency}
                unless $content{currency} =~ /^(CAD|USD)$/;
        
-       $content{taxes} ||= '';
-       $content{taxes} = uc $content{taxes};
+       $content{taxes} = uc($content{taxes} || '');
 
        my %data = $self->get_remap_fields(qw(
                        xxxCard_Number          card_number