Confusion around card types

[Business-OnlinePayment-InternetSecure.git] / InternetSecure.pm

diff --git a/InternetSecure.pm b/InternetSecure.pm
index 58a6ce7..e3855cf 100755 (executable)
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -18,8 +18,9 @@ our $VERSION = '0.01';
 use constant CARD_TYPES => {
                                VI => 'Visa',
                                MC => 'MasterCard',
-                               AX => 'American Express',
+                               AX => 'American Express', # FIXME: AM?
                                NN => 'Discover',
+                               # JB?
                        };
 
 
@@ -43,6 +44,18 @@ sub set_defaults {
                        ));
 }
 
+# OnlinePayment's get_fields now filters out undefs in 3.x. :(
+#
+sub get_fields {
+       my ($self, @fields) = @_;
+
+       my %content = $self->content;
+
+       my %new = map +($_ => $content{$_}), @fields;
+
+       return %new;
+}
+
 # OnlinePayment's remap_fields is buggy, so we simply rewrite it
 #
 sub remap_fields {
@@ -63,10 +76,6 @@ sub get_remap_fields {
        $self->remap_fields(reverse %map);
        my %data = $self->get_fields(keys %map);
 
-       foreach (values %data) {
-               $_ = '' unless defined;
-       }
-
        return %data;
 }
 
@@ -149,7 +158,7 @@ sub to_xml {
        $content{taxes} = uc $content{taxes};
 
        my %data = $self->get_remap_fields(qw(
-                       xxxCardNumber           card_number
+                       xxxCard_Number          card_number
 
                        xxxName                 name
                        xxxCompany              company
@@ -174,7 +183,7 @@ sub to_xml {
        
        $data{MerchantNumber} = $self->merchant_id;
 
-       $data{xxxCardNumber} =~ tr/ //d;
+       $data{xxxCard_Number} =~ tr/ //d;
 
        my ($y, $m) = $self->parse_expdate($content{exp_date});
        $data{xxxCCYear} = sprintf '%.4u' => $y;
@@ -207,6 +216,7 @@ sub to_xml {
        xml_out(\%data,
                NoAttr => 1,
                RootName => 'TranxRequest',
+               SuppressEmpty => undef,
                XMLDecl => '<?xml version="1.0" encoding="utf-8" standalone="yes"?>',
        );
 }