Removed useless cardholder field

[Business-OnlinePayment-InternetSecure.git] / InternetSecure.pm

diff --git a/InternetSecure.pm b/InternetSecure.pm
index e3855cf..c70b79f 100755 (executable)
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -38,7 +38,7 @@ sub set_defaults {
 
        $self->build_subs(qw(
                                receipt_number  sales_order_number
-                               cardholder      card_type
+                               card_type
                                total_amount
                                avs_response    cvv2_response
                        ));
@@ -184,6 +184,7 @@ sub to_xml {
        $data{MerchantNumber} = $self->merchant_id;
 
        $data{xxxCard_Number} =~ tr/ //d;
+       $data{xxxCard_Number} =~ s/^[0-36-9]/4/ if $self->test_transaction;
 
        my ($y, $m) = $self->parse_expdate($content{exp_date});
        $data{xxxCCYear} = sprintf '%.4u' => $y;
@@ -253,7 +254,6 @@ sub parse_response {
        $self->infuse($response, qw(
                        ReceiptNumber           receipt_number
                        SalesOrderNumber        sales_order_number
-                       xxxName                 cardholder
                        CardType                card_type
                        Page                    result_code
                        ApprovalCode            authorization
@@ -263,6 +263,9 @@ sub parse_response {
                        CVV2ResponseCode        cvv2_response
                ));
        
+       # Completely undocumented field that sometimes override <Verbiage>
+       $self->error_message($response->{Error}) if $response->{Error};
+       
        $self->card_type(CARD_TYPES->{$self->card_type});
        
        $self->{products_raw} = $response->{Products};
@@ -447,9 +450,8 @@ separating them with spaces, such as C<GST HST>.
 
 =item name / company / address / city / state / zip / country / phone / email
 
-Facultative customer information.  B<state> should be either a postal
-abbreviation or a two-letter code taken from ISO 3166-2, and B<country> should
-be a two-letter code taken from ISO 3166-1.
+Customer information.  B<Country> should be a two-letter code taken from ISO
+3166-1.
 
 =back
 
@@ -467,11 +469,6 @@ Receipt number and sales order number of submitted order.
 
 Total amount billed for this order, including taxes.
 
-=item cardholder()
-
-Cardholder's name.  This is currently a mere copy of the B<name> field passed
-to B<submit()>.
-
 =item card_type()
 
 Type of the credit card used for the submitted order, being one of the
@@ -519,7 +516,7 @@ Unit price of this product.
 
 =item quantity
 
-Ordered quantity of this product.  This can be a decimal value.
+Ordered quantity of this product.
 
 =item sku