use base qw(Business::OnlinePayment Exporter);
-our $VERSION = '0.01';
+our $VERSION = '0.02';
use constant SUCCESS_CODES => qw(2000 90000 900P1);
use constant CARD_TYPES => {
- VI => 'Visa',
+ AM => 'American Express',
+ JB => 'JCB',
MC => 'MasterCard',
- AX => 'American Express', # FIXME: AM?
NN => 'Discover',
- # JB?
+ VI => 'Visa',
};
receipt_number sales_number uuid guid
date
card_type cardholder
- total_amount taxes
+ total_amount tax_amounts
avs_response cvv2_response
));
- # Just in case someone tries to call taxes() *before* submit()
- $self->taxes( {} );
+ # Just in case someone tries to call tax_amounts() *before* submit()
+ $self->tax_amounts( {} );
}
# OnlinePayment's get_fields now filters out undefs in 3.x. :(
return %new;
}
+# OnlinePayment's remap_fields is buggy in 2.x; this is copied from 3.x
+#
+sub remap_fields {
+ my ($self, %map) = @_;
+
+ my %content = $self->content();
+ foreach (keys %map) {
+ $content{$map{$_}} = delete $content{$_};
+ }
+ $self->content(%content);
+}
+
# Combine get_fields and remap_fields for convenience
#
sub get_remap_fields {
my @flags = ($currency);
- foreach (ref $data{taxes} ?
- @{ $data{taxes} } :
- split(' ' => $data{taxes} || '')) {
+ my @taxes;
+ if (ref $data{taxes}) {
+ @taxes = @{ $data{taxes} };
+ } elsif ($data{taxes}) {
+ @taxes = split ' ' => $data{taxes};
+ }
+
+ foreach (@taxes) {
croak "Unknown tax code $_" unless /^(GST|PST|HST)$/i;
push @flags, uc $_;
}
$self->required_fields(qw(action card_number exp_date));
- croak 'Unsupported transaction type'
- if $content{type} && $content{type} !~
- /^(Visa|MasterCard|American Express|Discover)$/i;
+ croak "Unsupported transaction type: $content{type}"
+ if $content{type} &&
+ ! grep lc($content{type}) eq lc($_),
+ values %{+CARD_TYPES};
croak 'Unsupported action'
unless $content{action} =~ /^Normal Authori[zs]ation$/i;
croak "Unknown currency code ", $content{currency}
unless $content{currency} =~ /^(CAD|USD)$/;
- $content{taxes} = uc($content{taxes} || '');
-
my %data = $self->get_remap_fields(qw(
xxxCard_Number card_number
);
}
- xml_out(\%data,
+ # The encode() makes sure to a) strip off non-Latin-1 characters, and
+ # b) turn off the utf8 flag, which confuses XML::Simple
+ encode('ISO-8859-1', xml_out(\%data,
NoAttr => 1,
- NumericEscape => 2,
RootName => 'TranxRequest',
SuppressEmpty => undef,
XMLDecl => '<?xml version="1.0" encoding="iso-8859-1" standalone="yes"?>',
- );
+ ));
}
# Map the various fields from the response, and put their values into our
}
}
-sub extract_taxes {
+sub extract_tax_amounts {
my ($self, $response) = @_;
- my %taxes;
+ my %tax_amounts;
my $products = $response->{Products};
return unless $products;
grep($_ eq '{TAX}', @$flags) &&
grep($_ eq '{CALCULATED}', @$flags))
{
- $taxes{ $node->{code} } = $node->{subtotal};
+ $tax_amounts{ $node->{code} } = $node->{subtotal};
}
}
- return %taxes;
+ return %tax_amounts;
}
# Parse the server's response and set various fields
$self->card_type(CARD_TYPES->{$self->card_type});
- $self->taxes( { $self->extract_taxes($response) } );
+ $self->tax_amounts( { $self->extract_tax_amounts($response) } );
return $self;
}
=item - Discover
+=item - JCB
+
=back
(This is actually ignored for the moment, and can be left blank or undefined.)
=item taxes
-Taxes to be added automatically to B<amount> by InternetSecure.
+Taxes to be added automatically to B<amount> by InternetSecure. Available
+taxes are C<GST>, C<PST> and C<HST>.
-Available taxes are C<GST>, C<PST> and C<HST>. Multiple taxes can specified
-by concatenating them with spaces, such as C<GST HST>.
+This argument can either be a single string of taxes concatenated with spaces
+(such as C<GST PST>), or a reference to an array of taxes (such as C<[ "GST",
+"PST" ]>).
=item name / company / address / city / state / zip / country / phone / email
Total amount billed for this order, including taxes.
-=item taxes()
+=item tax_amounts()
-Returns a I<reference> to a hash that maps tax names (such as C<GST>) to the
-amount that was billed for each.
+Returns a I<reference> to a hash that maps taxes, which were listed under the
+B<taxes> argument to B<submit>(), to the amount that was calculated by
+InternetSecure.
=item cardholder()
=item - Discover
+=item - JCB
+
=back
=over 4
-=item amount
+=item amount (required)
Unit price of this product.
=head2 Character encoding
-Since communication to/from InternetSecure is encoded with UTF-8, all Unicode
-characters are theoretically available when submitting information via
-B<submit>(). (Further restrictions may be imposed by InternetSecure itself.)
+When using non-ASCII characters, all data provided to B<contents>() should
+have been decoded beforehand via the C<Encode> module, unless your data is in
+ISO-8859-1 and you haven't meddled with the C<encoding> pragma. (Please
+don't.)
-When using non-ASCII characters, all data provided to B<submit>() should either
-be in the current native encoding (typically latin-1, unless it was modified
-via the C<encoding> pragma), or be decoded via the C<Encode> module.
-Conversely, all data returned after calling B<submit>() will be automatically
-decoded.
+InternetSecure currently does not handle characters outside of ISO-8859-1, so
+these will be replaced with C<?> before being transmitted.
=head1 EXPORT
projects / Business-OnlinePayment-InternetSecure.git / blobdiff