Rewrote docs a bit

[Business-OnlinePayment-InternetSecure.git] / InternetSecure.pm

diff --git a/InternetSecure.pm b/InternetSecure.pm
index 65a9112..591c98d 100755 (executable)
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -37,7 +37,7 @@ sub set_defaults {
        $self->path('/process.cgi');
 
        $self->build_subs(qw(
-                               receipt_number  sales_order_number
+                               receipt_number  sales_number
                                card_type
                                total_amount
                                avs_response    cvv2_response
@@ -148,13 +148,11 @@ sub to_xml {
        croak 'Unsupported action'
                unless $content{action} =~ /^Normal Authori[zs]ation$/i;
        
-       $content{currency} ||= 'CAD';
-       $content{currency} = uc $content{currency};
+       $content{currency} = uc($content{currency} || 'CAD');
        croak "Unknown currency code ", $content{currency}
                unless $content{currency} =~ /^(CAD|USD)$/;
        
-       $content{taxes} ||= '';
-       $content{taxes} = uc $content{taxes};
+       $content{taxes} = uc($content{taxes} || '');
 
        my %data = $self->get_remap_fields(qw(
                        xxxCard_Number          card_number
@@ -252,7 +250,7 @@ sub parse_response {
 
        $self->infuse($response, qw(
                        ReceiptNumber           receipt_number
-                       SalesOrderNumber        sales_order_number
+                       SalesOrderNumber        sales_number
                        CardType                card_type
                        Page                    result_code
                        ApprovalCode            authorization
@@ -364,7 +362,8 @@ to the merchant ID assigned to you by InternetSecure.
 
 =head1 METHODS
 
-(See L<Business::OnlinePayment> for more methods.)
+(Other methods are also available -- see L<Business::OnlinePayment> for more
+details.)
 
 =head2 Before order submission
 
@@ -427,12 +426,14 @@ Code (CVC2) or Card Identification number (CID), depending on the card issuer.
 A short description of the purchase.  See L<"Products list syntax"> for
 an alternate syntax that allows a list of products to be specified.
 
-=item amount
+=item amount (usually required)
+
+Total amount to be billed, excluding taxes if they are to be added separately
+by InternetSecure.
 
-Total amount to be billed, excluding taxes if they are to be added separately.
-This field is required if B<description> is a string, and should be left
-undefined if B<description> contains a list of products, as outlined in
-L<"Products list syntax">.
+This field is required if B<description> is a string, but should be left
+undefined if B<description> contains a list of products instead, as outlined
+in L<"Products list syntax">.
 
 =item currency
 
@@ -441,11 +442,10 @@ C<CAD> (default) or C<USD>.
 
 =item taxes
 
-Taxes to be added automatically.  These should not be included in B<amount>;
-they will be automatically added by InternetSecure later on.
+Taxes to be added automatically to B<amount> by InternetSecure.
 
-Available taxes are C<GST>, C<PST> and C<HST>.  Taxes can be combined by
-separating them with spaces, such as C<GST HST>.
+Available taxes are C<GST>, C<PST> and C<HST>.  Multiple taxes can specified
+by concatenating them with spaces, such as C<GST HST>.
 
 =item name / company / address / city / state / zip / country / phone / email
 
@@ -460,9 +460,15 @@ Customer information.  B<Country> should be a two-letter code taken from ISO
 
 =over 4
 
-=item receipt_number() / sales_order_number()
+=item receipt_number()
+
+Receipt number of this transaction; this is actually a string, unique to all
+InternetSecure transactions.
+
+=item sales_number()
 
-Receipt number and sales order number of submitted order.
+Sales order number of this transaction.  This is a number, unique to each
+merchant, which is incremented by 1 each time.
 
 =item total_amount()