From: Ivan Kohler <ivan@freeside.biz>
Date: Sat, 22 Sep 2012 07:09:40 +0000 (-0700)
Subject: Add link to Neil Bowers' review of CC check modules
X-Git-Url: http://git.freeside.biz/gitweb/?p=Business-CreditCard.git;a=commitdiff_plain;h=40e39c3bee2cc3c7ab67339f0b66a7982e076ee6

Add link to Neil Bowers' review of CC check modules
---

diff --git a/Changes b/Changes
index f90aa40..2a413fb 100644
--- a/Changes
+++ b/Changes
@@ -4,6 +4,7 @@ Revision history for Perl extension Business::CreditCard.
         - Add Israeli Isracard (no checksum yet)
         - Add LICENSE=>perl to Makefile.PL; add license to META.yml,
           closes: cpan #27735
+        - Documentation: Add link to Neil Bowers' review of CC check modules
 
 0.31  Mon Oct 19 18:51:35 PDT 2009
         - Add LICENSE section to POD documentation
diff --git a/CreditCard.pm b/CreditCard.pm
index df40315..d657e42 100644
--- a/CreditCard.pm
+++ b/CreditCard.pm
@@ -131,12 +131,24 @@ types.  Lee also contributed a working test.pl.  Alexandr Ciornii
 
 Copyright (C) 1995,1996,1997 Jon Orwant
 Copyright (C) 2001-2006 Ivan Kohler
-Copyright (C) 2007-2011 Freeside Internet Services, Inc.
+Copyright (C) 2007-2012 Freeside Internet Services, Inc.
 
 This library is free software; you can redistribute it and/or modify
 it under the same terms as Perl itself, either Perl version 5.8.8 or,
 at your option, any later version of Perl 5 you may have available.
 
+=head1 BUGS
+
+(paraphrasing Neil Bowers) We export all functions by default.  It would be
+better to let the user decide which functions to import.  And validate() is
+a bit of a generic name.
+
+The question is, after almost 2 decades with this interface (inherited from
+the original author, who probably never expected it to live half this long),
+how to change things to behave in a more modern fashion without breaking
+existing code?  "use Business::CreditCard <some_minimum_version>" turns it off?
+Explicitly ask to turn it off and list that in the SYNOPSIS?
+
 =head1 SEE ALSO
 
 L<Business::CreditCard::Object> is a wrapper around Business::CreditCard
@@ -146,6 +158,9 @@ Business::CreditCard distribution is welcome.
 L<Business::OnlinePayment> is a framework for processing online payments
 including modules for various payment gateways.
 
+http://neilb.org/reviews/luhn.html is an excellent overview of similar modules
+providing credit card number verification (LUHN checking).
+
 =cut
 
 @EXPORT = qw(cardtype validate generate_last_digit);