From: ivan <ivan>
Date: Thu, 5 May 2011 23:21:23 +0000 (+0000)
Subject: fix double insert of overpayments, RT#12655
X-Git-Tag: freeside_2_1_3~221
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=dd95700348ce86de5ec76887a00f480172710950;p=freeside.git

fix double insert of overpayments, RT#12655
---

diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm
index 5746f4140..0dd427645 100644
--- a/FS/FS/cust_main/Billing_Realtime.pm
+++ b/FS/FS/cust_main/Billing_Realtime.pm
@@ -810,6 +810,7 @@ sub _realtime_bop_result {
     my $error = $cust_pay->insert($options{'manual'} ? ( 'manual' => 1 ) : () );
 
     if ( $error ) {
+      $dbh->rollback or die $dbh->errstr if $oldAutoCommit;
       $cust_pay->invnum(''); #try again with no specific invnum
       $cust_pay->paynum('');
       my $error2 = $cust_pay->insert( $options{'manual'} ?