From: Mitch Jackson <mitch@freeside.biz>
Date: Sun, 20 May 2018 00:51:03 +0000 (-0500)
Subject: RT# 78190 Fix bill summary missing taxes or fees
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=c34212f6b04a6796467ad1fb5d32154eae1ea40d;p=freeside.git

RT# 78190 Fix bill summary missing taxes or fees
---

diff --git a/FS/FS/Template_Mixin.pm b/FS/FS/Template_Mixin.pm
index 51f89f717..c90e65245 100644
--- a/FS/FS/Template_Mixin.pm
+++ b/FS/FS/Template_Mixin.pm
@@ -1417,13 +1417,12 @@ sub print_generic {
         $tax_section->{'description'} = $self->mt($tax_description);
         $tax_section->{'summarized'} = '';
 
-        if ( !grep $tax_section, @sections ) {
+        # append tax section unless it's already there
+        push @sections, $tax_section
+          unless grep {$_ eq $tax_section} @sections;
 
-          # append it if it's not already there
-          push @sections, $tax_section;
-          push @summary_subtotals, $tax_section;
-
-        }
+        push @summary_subtotals, $tax_section
+          unless grep {$_ eq $tax_section} @summary_subtotals;
 
       }
     } else {