From: ivan <ivan>
Date: Thu, 19 Nov 2009 06:21:32 +0000 (+0000)
Subject: consider credits and refunds in breakage, RT#6407
X-Git-Tag: freeside_1_9_2~224
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=b3d8c129d76c0adaf247d1f3fc8597ea5ba280cb;p=freeside.git

consider credits and refunds in breakage, RT#6407
---

diff --git a/FS/FS/Cron/breakage.pm b/FS/FS/Cron/breakage.pm
index 69758f9c5..6dd904d6a 100644
--- a/FS/FS/Cron/breakage.pm
+++ b/FS/FS/Cron/breakage.pm
@@ -30,19 +30,19 @@ sub reconcile_breakage {
       if $opt{'v'};
 
     #find customers w/negative balance older than $days (and no activity since)
-    # no invoices / payments (/credits/refunds?) newer than $since
-    #  (except antother breakage invoice???)
-
-    my $extra_sql = ' AND 0 > '. FS::cust_main->balance_sql;
-    $extra_sql .= " AND ". join(' AND ',
-      map {"
-            NOT EXISTS ( SELECT 1 FROM $_
-                           WHERE $_.custnum = cust_main.custnum
-                             AND _date >= $since
-                       )
-          ";}
-          qw( cust_bill cust_pay ) # cust_credit cust_refund );
-    );
+    # and no activity (invoices/payments/credits/refunds) newer than $since
+    #  (XXX except antother breakage invoice???)
+
+    my $extra_sql =
+      ' AND 0 > '. FS::cust_main->balance_sql.
+      ' AND '. join(' AND ', map {
+        " NOT EXISTS (
+            SELECT 1 FROM $_
+              WHERE $_.custnum = cust_main.custnum
+                AND _date >= $since
+          ) "
+        } qw( cust_bill cust_pay cust_credit cust_refund )
+      );
 
     my @customers = qsearch({
       'table'     => 'cust_main',